| Summary: | [iOS] Add a quirk to keep gizmodo videos visible when playing in fullscreen. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||||
| Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | darin, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | Other | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Eric Carlson
2020-04-22 07:40:19 PDT
Created attachment 397189 [details]
Patch
Comment on attachment 397189 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397189&action=review > Source/WebCore/style/StyleAdjuster.cpp:37 > +#include "HTMLDivElement.h" Also need to include "HTMLVideoElement.h". > Source/WebCore/style/StyleAdjuster.cpp:565 > + if (video && is<HTMLVideoElement>(video) && downcast<HTMLVideoElement>(*video).isFullscreen()) No needful the "video &&" part, since is<>(video) does a null check. Created attachment 397202 [details]
Patch
Created attachment 397206 [details]
Patch
Comment on attachment 397189 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397189&action=review >> Source/WebCore/style/StyleAdjuster.cpp:565 >> + if (video && is<HTMLVideoElement>(video) && downcast<HTMLVideoElement>(*video).isFullscreen()) > > No needful the "video &&" part, since is<>(video) does a null check. Good point, thanks. Committed r260524: <https://trac.webkit.org/changeset/260524> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397206 [details]. |