Bug 210857

Summary: [iOS] Add a quirk to keep gizmodo videos visible when playing in fullscreen.
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Eric Carlson
Reported 2020-04-22 07:40:19 PDT
Don't allow `display:none` on a video element ancestor when in fullscreen.
Attachments
Patch (7.66 KB, patch)
2020-04-22 07:53 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (7.85 KB, patch)
2020-04-22 09:21 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (7.84 KB, patch)
2020-04-22 09:26 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2020-04-22 07:42:26 PDT
<rdar://problem/58875327>
Eric Carlson
Comment 2 2020-04-22 07:53:57 PDT
Created attachment 397189 [details] Patch
Darin Adler
Comment 3 2020-04-22 08:43:40 PDT
Comment on attachment 397189 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397189&action=review > Source/WebCore/style/StyleAdjuster.cpp:37 > +#include "HTMLDivElement.h" Also need to include "HTMLVideoElement.h". > Source/WebCore/style/StyleAdjuster.cpp:565 > + if (video && is<HTMLVideoElement>(video) && downcast<HTMLVideoElement>(*video).isFullscreen()) No needful the "video &&" part, since is<>(video) does a null check.
Eric Carlson
Comment 4 2020-04-22 09:21:52 PDT
Created attachment 397202 [details] Patch
Eric Carlson
Comment 5 2020-04-22 09:26:52 PDT
Created attachment 397206 [details] Patch
Eric Carlson
Comment 6 2020-04-22 09:45:49 PDT
Comment on attachment 397189 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397189&action=review >> Source/WebCore/style/StyleAdjuster.cpp:565 >> + if (video && is<HTMLVideoElement>(video) && downcast<HTMLVideoElement>(*video).isFullscreen()) > > No needful the "video &&" part, since is<>(video) does a null check. Good point, thanks.
EWS
Comment 7 2020-04-22 11:38:41 PDT
Committed r260524: <https://trac.webkit.org/changeset/260524> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397206 [details].
Note You need to log in before you can comment on or make changes to this bug.