Bug 21081

Summary:

Inline immediate case of op_neq

Product:

WebKit

Reporter:

Maciej Stachowiak <mjs>

Component:

JavaScriptCore

Assignee:

Maciej Stachowiak <mjs>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
patch v1	oliver: review+

Description Maciej Stachowiak 2008-09-24 17:07:46 PDT

Richards spends a fair amount of time in not-equal comparisons, much of it the immediate case, which could be inlined.

Comment 1 Maciej Stachowiak 2008-09-24 17:08:18 PDT

Created attachment 23773 [details]
patch v1

Comment 2 Oliver Hunt 2008-09-24 17:16:16 PDT

Comment on attachment 23773 [details]
patch v1

It seems really unfortunate that you don't inline all immediate cases :-/

Comment 3 Maciej Stachowiak 2008-09-24 17:25:44 PDT

I could probably inline more of them, but there are various weird special cases, such as true == 1, false == 0. We have a special opcode for comparing to null, so booleans and undefined are the only immediates missing fast cases.

Comment 4 Darin Adler 2008-10-12 18:02:19 PDT

http://trac.webkit.org/changeset/36876