Bug 210781
| Summary: | logLevelString() is declared in both LogInitialization.h and in Logging.h | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | darin |
| Priority: | P2 | ||
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=210724 | ||
David Kilzer (:ddkilzer)
logLevelString() is declared in both LogInitialization.h and in Logging.h.
Not only that, but the same issue exists in both Source/WebCore/platform and Source/WebKit/Platform.
Also, the path and file name of Source/WebKit/Platform/foundation/LoggingFoundation.mm should use "cocoa" instead of "foundation".
See discussion starting in Bug 210724, Comment #11 to Bug 210724, Comment #14:
<https://bugs.webkit.org/show_bug.cgi?id=210724#c11>
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Darin Adler
Not sure about that "Foundation" vs. "Cocoa" part. It’s OK to not make a distinction, but this logging doesn’t depend on the higher levels of Cocoa like NSView/UIView.