Summary: | Intl classes shouldn't need an m_initialized* field | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||||||
Component: | New Bugs | Assignee: | Ross Kirsling <ross.kirsling> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Ross Kirsling
2020-04-20 13:36:54 PDT
Created attachment 397012 [details]
Patch
Comment on attachment 397012 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397012&action=review > Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:61 > + IntlNumberFormatField(int32_t type, int32_t size) > + : type(type) > + , size(size) > + { } Typically this should not be necessary. > Source/JavaScriptCore/runtime/IntlPluralRules.cpp:94 > Vector<String> data; > return data; return { }; Created attachment 397027 [details]
Patch for landing
Created attachment 397034 [details]
Patch for landing
Committed r260411: <https://trac.webkit.org/changeset/260411> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397034 [details]. |