Bug 210764

Summary: Intl classes shouldn't need an m_initialized* field
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Description Ross Kirsling 2020-04-20 13:36:54 PDT
Intl classes shouldn't need an m_initialized* field
Comment 1 Ross Kirsling 2020-04-20 14:11:41 PDT
Created attachment 397012 [details]
Patch
Comment 2 Darin Adler 2020-04-20 14:55:48 PDT
Comment on attachment 397012 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397012&action=review

> Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:61
> +    IntlNumberFormatField(int32_t type, int32_t size)
> +        : type(type)
> +        , size(size)
> +    { }

Typically this should not be necessary.

> Source/JavaScriptCore/runtime/IntlPluralRules.cpp:94
>      Vector<String> data;
>      return data;

return { };
Comment 3 Ross Kirsling 2020-04-20 15:51:30 PDT
Created attachment 397027 [details]
Patch for landing
Comment 4 Ross Kirsling 2020-04-20 16:15:48 PDT
Created attachment 397034 [details]
Patch for landing
Comment 5 EWS 2020-04-20 21:04:15 PDT
Committed r260411: <https://trac.webkit.org/changeset/260411>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397034 [details].
Comment 6 Radar WebKit Bug Importer 2020-04-20 21:05:19 PDT
<rdar://problem/62089736>