Bug 210752

Summary:

Fix CheckIsConstant for non-constant values and checking for empty

Product:

WebKit

Reporter:

Keith Miller <keith_miller>

Component:

New Bugs

Assignee:

Keith Miller <keith_miller>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Keith Miller 2020-04-20 10:25:54 PDT

Fix CheckIsConstant for non-constant values and checking for empty

Comment 1 Keith Miller 2020-04-20 10:26:41 PDT

Created attachment 396987 [details]
Patch

Comment 2 Keith Miller 2020-04-20 10:33:28 PDT

Created attachment 396989 [details]
Patch

Comment 3 Saam Barati 2020-04-20 10:37:27 PDT

Comment on attachment 396989 [details]
Patch

test?

Comment 4 Keith Miller 2020-04-20 10:37:45 PDT

(In reply to Saam Barati from comment #3)
> Comment on attachment 396989 [details]
> Patch
> 
> test?

ToT has broken tests.

Comment 5 EWS 2020-04-20 11:06:31 PDT

Committed r260377: <https://trac.webkit.org/changeset/260377>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396989 [details].

Comment 6 Radar WebKit Bug Importer 2020-04-20 11:07:42 PDT

<rdar://problem/62066519>