Bug 210751

Summary: Exit early in FrameLoader::loadURL when redirecting to another frame
Product: WebKit Reporter: Rob Buis <rbuis>
Component: New BugsAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, ews-watchlist, ggaren, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Rob Buis
Reported 2020-04-20 10:10:09 PDT
Exit early in FrameLoader::loadURL when redirecting to another frame, previously we were preparing request needlessly, doing it twice in case of frame redirecting. Also move some variables to where they are actually used.
Attachments
Patch (4.40 KB, patch)
2020-04-20 10:11 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (4.43 KB, patch)
2020-04-21 00:09 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (5.02 KB, patch)
2020-04-21 01:22 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-04-20 10:11:58 PDT
Created attachment 396984 [details] Patch
Geoffrey Garen
Comment 2 2020-04-20 11:47:36 PDT
Comment on attachment 396984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396984&action=review r=me > Source/WebCore/loader/FrameLoader.cpp:1358 > + Frame* targetFrame = isFormSubmission ? nullptr : findFrameForNavigation(effectiveFrameName); This should be RefPtr.
Darin Adler
Comment 3 2020-04-20 12:39:11 PDT
Comment on attachment 396984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396984&action=review >> Source/WebCore/loader/FrameLoader.cpp:1358 >> + Frame* targetFrame = isFormSubmission ? nullptr : findFrameForNavigation(effectiveFrameName); > > This should be RefPtr. I think our latest style would be: auto targetFrame = isFormSubmission ? nullptr : makeRefPtr(findFrameForNavigation(effectiveFrameName)); Or change findFrameForNavigation to return a RefPtr. Move the makeRefPtr outside the ? : if needed to make things compile.
Rob Buis
Comment 4 2020-04-21 00:09:45 PDT
Created attachment 397060 [details] Patch
Rob Buis
Comment 5 2020-04-21 01:22:43 PDT
Created attachment 397062 [details] Patch
EWS
Comment 6 2020-04-21 03:31:13 PDT
Committed r260423: <https://trac.webkit.org/changeset/260423> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397062 [details].
Radar WebKit Bug Importer
Comment 7 2020-04-21 03:32:13 PDT
<rdar://problem/62099510>
Note You need to log in before you can comment on or make changes to this bug.