Bug 210737

Summary: [Flatpak SDK] Prevent exception when calling git in a non-git repository
Product: WebKit Reporter: Diego Pino <dpino>
Component: New BugsAssignee: Diego Pino <dpino>
Status: RESOLVED FIXED    
Severity: Normal CC: pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Diego Pino
Reported 2020-04-20 01:07:59 PDT
[Flatpak SDK] Prevent exception when calling git in a non-git repository
Attachments
Patch (1.65 KB, patch)
2020-04-20 01:09 PDT, Diego Pino 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Diego Pino
Comment 1 2020-04-20 01:09:17 PDT
Created attachment 396957 [details] Patch
Diego Pino
Comment 2 2020-04-20 01:13:04 PDT
This error came up when I tried to switch the WPE build bot to flatpak: https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Release%20%28Build%29/builds/31955/steps/compile-webkit/logs/stdio I think it didn't work because the bot uses SVN to fetch the code (https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Release%20%28Build%29/builds/31955)
Diego Pino
Comment 3 2020-04-20 03:14:43 PDT
*** This bug has been marked as a duplicate of bug 210557 ***
Philippe Normand
Comment 4 2020-04-20 08:18:21 PDT
Sorry, this isn't a duplicate actually. It's a valid patch, thanks Diego :)
EWS
Comment 5 2020-04-20 08:24:21 PDT
Committed r260365: <https://trac.webkit.org/changeset/260365> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396957 [details].
Radar WebKit Bug Importer
Comment 6 2020-04-20 08:25:13 PDT
<rdar://problem/62058978>
Note You need to log in before you can comment on or make changes to this bug.