Bug 210732

Summary: Content disappears on CSS parallax example
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://googlechromelabs.github.io/ui-element-samples/parallax/
Attachments:
Description Flags
Patch
darin: review+
Patch
none
Patch ews-feeder: commit-queue-

Description Simon Fraser (smfr) 2020-04-19 22:09:58 PDT 
Content disappears on CSS parallax example
Comment 1 Simon Fraser (smfr) 2020-04-19 22:14:13 PDT 
Created attachment 396942 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-04-19 22:14:15 PDT 
<rdar://problem/61997636>
Comment 3 Simon Fraser (smfr) 2020-04-19 22:28:28 PDT 
Created attachment 396943 [details]
Patch
Comment 4 Darin Adler 2020-04-19 22:49:46 PDT 
That new patch is a two-for-one!
Comment 5 Simon Fraser (smfr) 2020-04-19 23:10:37 PDT 
Oh whoops. I wish webkit-patch supported --git-index like prepare-Changelogs does.
Comment 6 Simon Fraser (smfr) 2020-04-19 23:11:04 PDT 
Created attachment 396945 [details]
Patch
Comment 7 EWS 2020-04-20 09:27:39 PDT 
Found 2 new test failures: compositing/tiling/coverage-adjustment-secondary-quad-mapping.html, fast/layoutformattingcontext/simple-absolute-positioned-replaced-inline-element-with-percentage-height.html
Comment 8 Simon Fraser (smfr) 2020-04-20 10:15:31 PDT 
https://trac.webkit.org/changeset/260371/webkit
Comment 9 Darin Adler 2020-04-20 10:31:48 PDT 
Comment on attachment 396942 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396942&action=review

> Source/WebCore/platform/graphics/transforms/TransformState.cpp:223
> +    if (direction == ApplyTransformDirection) {
>          quad = m_accumulatedTransform->mapQuad(quad);
> +        return;
> +    }
>  
>      quad = m_accumulatedTransform->inverse().valueOr(TransformationMatrix()).projectQuad(quad, wasClamped);

I should have suggested else instead of return.
Comment 10 Simon Fraser (smfr) 2020-04-20 11:46:24 PDT 
I used return to mirror the mapPoint() code above.
Comment 11 Darin Adler 2020-04-20 12:03:23 PDT 
(In reply to Simon Fraser (smfr) from comment #10)
> I used return to mirror the mapPoint() code above.

I suggested else to mirror translateTransform above. We just happened to look at different functions.