Bug 210726

Summary: [JSC] Enable BigInt
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, keith_miller, mark.lam, msaboff, saam, simon.fraser, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=179001
https://bugs.webkit.org/show_bug.cgi?id=210731
https://bugs.webkit.org/show_bug.cgi?id=210735
Attachments:
Description Flags
Patch mark.lam: review+

Description Yusuke Suzuki 2020-04-19 17:06:18 PDT
[JSC] Enable BigInt
Comment 1 Yusuke Suzuki 2020-04-19 17:10:38 PDT
Created attachment 396930 [details]
Patch
Comment 2 Mark Lam 2020-04-19 17:12:24 PDT
Comment on attachment 396930 [details]
Patch

r=me
Comment 3 Yusuke Suzuki 2020-04-19 17:59:05 PDT
Committed r260345: <https://trac.webkit.org/changeset/260345>
Comment 4 Radar WebKit Bug Importer 2020-04-19 18:00:17 PDT
<rdar://problem/62035906>
Comment 5 Yusuke Suzuki 2020-04-19 19:17:20 PDT
https://bugs.webkit.org/show_bug.cgi?id=210728
Comment 6 Simon Fraser (smfr) 2020-04-19 21:54:04 PDT
This is causing test crashes: bug 210731.
Comment 7 Simon Fraser (smfr) 2020-04-19 21:54:30 PDT
Why was this landed with crashing tests in EWS?
Comment 8 Yusuke Suzuki 2020-04-20 02:59:23 PDT
(In reply to Simon Fraser (smfr) from comment #6)
> This is causing test crashes: bug 210731.

This is existing IDB bug. bug 210731 describes the details.
In bug 210731, we skipped this test. Here is analysis https://bugs.webkit.org/show_bug.cgi?id=210731#c3 and this is rationale. https://trac.webkit.org/changeset/260352/webkit
Comment 9 Yusuke Suzuki 2020-04-20 03:00:27 PDT
(In reply to Yusuke Suzuki from comment #8)
> (In reply to Simon Fraser (smfr) from comment #6)
> > This is causing test crashes: bug 210731.
> 
> This is existing IDB bug. bug 210731 describes the details.
> In bug 210731, we skipped this test. Here is analysis
> https://bugs.webkit.org/show_bug.cgi?id=210731#c3 and this is rationale.
> https://trac.webkit.org/changeset/260352/webkit

And tracked in https://bugs.webkit.org/show_bug.cgi?id=210735