Bug 210665

Summary: REGRESSION(r260246): It broke build on MIPS32
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, angelos, bugs-noreply, dpino, ews-watchlist, guijemont, keith_miller, mark.lam, msaboff, rmorisset, sbarati, ticaiolima, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 210639    
Attachments:
Description Flags
Patch none

Description Carlos Alberto Lopez Perez 2020-04-17 12:27:20 PDT
MIPS32 Build its failing to build since r260246 with this error:

FAILED: [...] Source/JavaScriptCore/CMakeFiles/LowLevelInterpreterLib.dir/llint/LowLevelInterpreter.cpp.o -c ../../Source/JavaScriptCore/llint/LowLevelInterpreter.cpp
/tmp/ccTewGul.s: Assembler messages:
/tmp/ccTewGul.s:9974: Error: unrecognized opcode `shv $t1,0($t5)'
/tmp/ccTewGul.s:10000: Error: unrecognized opcode `shv $t8,0($t5)'
/tmp/ccTewGul.s:10076: Error: unrecognized opcode `shv $t1,0($t5)'
/tmp/ccTewGul.s:10102: Error: unrecognized opcode `shv $t8,0($t5)'
/tmp/ccTewGul.s:10180: Error: unrecognized opcode `shv $t1,0($t5)'
/tmp/ccTewGul.s:10206: Error: unrecognized opcode `shv $t8,0($t5)'
/tmp/ccTewGul.s:10297: Error: unrecognized opcode `shv $t8,0($t5)'
[...repeated..]

See full failure log here: https://build.webkit.org/builders/JSCOnly%20Linux%20MIPS32el%20Release/builds/4845/steps/compile-webkit/logs/stdio

This has been bisected in the bot:
ordered build on r260245: worked (I stopped it on the test phase) -> https://build.webkit.org/builders/JSCOnly%20Linux%20MIPS32el%20Release/builds/4844
ordered build on r260246: failed -> https://build.webkit.org/builders/JSCOnly%20Linux%20MIPS32el%20Release/builds/4845

And to discard it was not an iterative build issue I also tested with clean builds:
clean ordered build on r260245: worked (the build phase) -> https://build.webkit.org/builders/JSCOnly%20Linux%20MIPS32el%20Release/builds/4847
clean ordered build on r260246: failed -> https://build.webkit.org/builders/JSCOnly%20Linux%20MIPS32el%20Release/builds/4846
Comment 1 Angelos Oikonomopoulos 2020-04-18 06:07:14 PDT
Created attachment 396843 [details]
Patch
Comment 2 EWS 2020-04-18 07:19:52 PDT
Committed r260309: <https://trac.webkit.org/changeset/260309>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396843 [details].
Comment 3 Radar WebKit Bug Importer 2020-04-18 07:20:18 PDT
<rdar://problem/61970528>