Summary: | REGRESSION (r162729): [iOS] WebKitTestRunner over-releases UITextField in WTR::PlatformWebView::removeChromeInputField() | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Component: | Tools / Tests | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, simon.fraser, webkit-bug-importer, wenson_hsieh | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=189228 https://bugs.webkit.org/show_bug.cgi?id=189464 |
||||||
Bug Depends on: | 127448 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2020-04-17 02:32:00 PDT
(In reply to David Kilzer (:ddkilzer) from comment #0) > NOTE: This may be the cause of some of the autoreleasePool crashes in > WebKitTestRunner that we see occasionally. The reason I say that is because this line will return an autoreleased object from UIKit under ARC: UITextField* textField = (UITextField*)[m_window viewWithTag:1]; And then the -release call over-releases the object. But we won't crash until the autoreleasePool containing the UITextField object is drained, which apparently doesn't happen consistently during test runs. Created attachment 396749 [details]
Patch v1
Committed r260250: <https://trac.webkit.org/changeset/260250> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396749 [details]. |