Bug 210640

Summary: MotionMark: ensure that timestamps are valid during warm up phase of tests
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: Layout and RenderingAssignee: Jon Lee <jonlee>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, ews-watchlist, jbedard, jonlee, rniwa, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Said Abou-Hallawa 2020-04-16 23:49:53 PDT
The MotionMark class Benchmark does not set its member _benchmarkStartTimestamp before it finishes warming up. This makes the getter 'timestamp' return NaN if it is called before finishing the warm up. Because of this, MotionMark might encounter a significant regression especially with the first test in the suite: the Multiply test.
Comment 1 Said Abou-Hallawa 2020-04-16 23:57:46 PDT
Created attachment 396744 [details]
Patch
Comment 2 Said Abou-Hallawa 2020-04-17 00:00:04 PDT
<rdar://problem/59363132>
Comment 3 Daniel Bates 2020-04-17 18:50:32 PDT
Comment on attachment 396744 [details]
Patch

Looks reasonable
Comment 4 Jon Lee 2020-04-23 22:29:36 PDT
Created attachment 397429 [details]
Patch
Comment 5 Said Abou-Hallawa 2020-04-24 10:48:16 PDT
Comment on attachment 397429 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397429&action=review

> PerformanceTests/MotionMark/about.html:76
> +                <li><strong>1.1.1</strong>: Fix bug in the calculation of timestamps used for animation during warm up phase of tests.</li>

Should we include a link to the bug in Bugzilla for more details about the bug itself and the fix?
Comment 6 Jon Lee 2020-04-24 10:52:29 PDT
(In reply to Said Abou-Hallawa from comment #5)
> Comment on attachment 397429 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=397429&action=review
> 
> > PerformanceTests/MotionMark/about.html:76
> > +                <li><strong>1.1.1</strong>: Fix bug in the calculation of timestamps used for animation during warm up phase of tests.</li>
> 
> Should we include a link to the bug in Bugzilla for more details about the
> bug itself and the fix?

Sure. I'll do that in a follow-up.
Comment 7 EWS 2020-04-24 10:59:01 PDT
Committed r260656: <https://trac.webkit.org/changeset/260656>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397429 [details].