Bug 210589 – REGRESSION (r260102): ASSERTION FAILED: m_arbitrators.contains(proxy) in WebKit::SharedArbitrator::endRoutingArbitrationForArbitrator

• Component: New Bugs
• Status: RESOLVED FIXED

[Jer Noble]

REGRESSION (r260102): ASSERTION FAILED: m_arbitrators.contains(proxy) in WebKit::SharedArbitrator::endRoutingArbitrationForArbitrator

[Jer Noble]

<rdar://problem/61844208>

[Jer Noble]

Created attachment 396607 [details]
Patch

[Eric Carlson]

Comment on attachment 396607 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396607&action=review

> Source/WebCore/platform/audio/mac/AudioSessionMac.mm:104
>          m_routingArbitrationClient->leaveRoutingAbritration();
> +        m_private->inRoutingArbitration = false;

Nit: I think it is generally a good idea to change the state before making the callback in case the callback results in a call back into this module.

[Jer Noble]

(In reply to Eric Carlson from comment #3)
> Comment on attachment 396607 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=396607&action=review
> 
> > Source/WebCore/platform/audio/mac/AudioSessionMac.mm:104
> >          m_routingArbitrationClient->leaveRoutingAbritration();
> > +        m_private->inRoutingArbitration = false;
> 
> Nit: I think it is generally a good idea to change the state before making
> the callback in case the callback results in a call back into this module.

Good point!

[Jer Noble]

Created attachment 396618 [details]
Patch for landing

[EWS]

Committed r260172: <https://trac.webkit.org/changeset/260172>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396618 [details].