Summary: | REGRESSION (r260102): ASSERTION FAILED: m_arbitrators.contains(proxy) in WebKit::SharedArbitrator::endRoutingArbitrationForArbitrator | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||
Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, peng.liu6, philipj, sergio, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Jer Noble
2020-04-15 20:00:29 PDT
Created attachment 396607 [details]
Patch
Comment on attachment 396607 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396607&action=review > Source/WebCore/platform/audio/mac/AudioSessionMac.mm:104 > m_routingArbitrationClient->leaveRoutingAbritration(); > + m_private->inRoutingArbitration = false; Nit: I think it is generally a good idea to change the state before making the callback in case the callback results in a call back into this module. (In reply to Eric Carlson from comment #3) > Comment on attachment 396607 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=396607&action=review > > > Source/WebCore/platform/audio/mac/AudioSessionMac.mm:104 > > m_routingArbitrationClient->leaveRoutingAbritration(); > > + m_private->inRoutingArbitration = false; > > Nit: I think it is generally a good idea to change the state before making > the callback in case the callback results in a call back into this module. Good point! Created attachment 396618 [details]
Patch for landing
Committed r260172: <https://trac.webkit.org/changeset/260172> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396618 [details]. |