Bug 210523

Summary: File Upload Menus presented from odd locations.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Megan Gardner
Reported 2020-04-14 16:43:07 PDT
File Upload Menus presented from odd locations.
Attachments
Patch (2.99 KB, patch)
2020-04-14 16:45 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (3.81 KB, patch)
2020-04-14 17:31 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2020-04-14 16:45:07 PDT
Created attachment 396476 [details] Patch
Megan Gardner
Comment 2 2020-04-14 16:46:08 PDT
<rdar://problem/60390846>
Wenson Hsieh
Comment 3 2020-04-14 16:53:47 PDT
Approach seems reasonable to me, but please test that presenting a context menu and then immediately tapping on a file picker (and vice versa) doesn’t break. We’ve had recent bugs where reusing preview containers for context menu/drag and drop have caused animation glitches.
Megan Gardner
Comment 4 2020-04-14 17:31:35 PDT
Created attachment 396482 [details] Patch
EWS
Comment 5 2020-04-14 21:13:51 PDT
Committed r260116: <https://trac.webkit.org/changeset/260116> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396482 [details].
Note You need to log in before you can comment on or make changes to this bug.