Summary: | Use CFArrayGetValues() in createArchiveList() in WebCoreArgumentCodersMac.mm | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Component: | WebKit2 | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | darin, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=210456 | ||||||
Bug Depends on: | 210448 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2020-04-14 15:48:08 PDT
Created attachment 396472 [details]
Patch v1
Comment on attachment 396472 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=396472&action=review > Source/WebKit/Shared/mac/WebCoreArgumentCodersMac.mm:127 > + for (size_t i = 0; i < static_cast<size_t>(*objectCount); ++i) { This line should not have been changed. There’s no reason to cast this just so we can use a different type for the loop. CFIndex is fine. Comment on attachment 396472 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=396472&action=review >> Source/WebKit/Shared/mac/WebCoreArgumentCodersMac.mm:127 >> + for (size_t i = 0; i < static_cast<size_t>(*objectCount); ++i) { > > This line should not have been changed. There’s no reason to cast this just so we can use a different type for the loop. CFIndex is fine. Will change back. I seem to recall there's a clang warning about using a signed type for an array index, which is why I changed it. Committed r260111: <https://trac.webkit.org/changeset/260111> |