|Summary:||Web Inspector: Console: treat long strings as non-simple so they aren't truncated|
|Product:||WebKit||Reporter:||Devin Rousso <drousso>|
|Component:||Web Inspector||Assignee:||Devin Rousso <drousso>|
|Severity:||Normal||CC:||drousso, inspector-bugzilla-changes, joepeck, webkit-bug-importer|
|Version:||WebKit Local Build|
Description Devin Rousso 2020-04-14 12:31:01 PDT
# STEPS TO REPRODUCE: 1. inspect any page 2. evaluate `console.log(true, "NaN".repeat(1000) + "Batman!");` 3. select the logged message and copy it 4. paste anywhere => only the first 140 characters of the string are copied, and there is no disclosure arrow to expand the message and allow the full string to be shown
Comment 3 Joseph Pecoraro 2020-04-14 12:41:27 PDT
Comment on attachment 396450 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396450&action=review So how does this look when you log a long string? > Source/WebInspectorUI/UserInterface/Views/FormattedValue.js:30 > +WI.FormattedValue.isSimpleString = function(string) Nice! Could be tested.
Comment 4 Devin Rousso 2020-04-14 13:10:04 PDT
Comment on attachment 396450 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396450&action=review > So how does this look when you log a long string? It looks the same as it does right now in that the truncated string is shown inline, but there's now a disclosure arrow that expands the list of non-simple arguments in the same way that `console.log(true, [globalThis]);` would, putting the full string on it's own line/item. >> Source/WebInspectorUI/UserInterface/Views/FormattedValue.js:30 >> +WI.FormattedValue.isSimpleString = function(string) > > Nice! Could be tested. I think this is simple enough that it doesn't need a test. If we change the maximum length in the future, having to remember to update a test as well seems like an extra unnecessary step. Plus, nothing else in this file is tested since it's really all view code.