Bug 210501 – [iPadOS] Wikipedia articles lay out incorrectly in 1/3 multitasking window

• Component: WebKit2
• Status: RESOLVED FIXED

[Wenson Hsieh]

<rdar://problem/54856323>

[Wenson Hsieh]

Created attachment 396423 [details]
en.wikipedia.org/wiki/Huawei (before)

[Wenson Hsieh]

Created attachment 396439 [details]
Patch

[Wenson Hsieh]

Created attachment 396440 [details]
en.wikipedia.org/wiki/Huawei (after)

[Tim Horton]

Comment on attachment 396439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396439&action=review

> Source/WebCore/page/Quirks.cpp:760
> +    return equalLettersIgnoringASCIICase(m_document->url().host(), "en.wikipedia.org");

You're missing like 160 subdomains

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:3892
> +        return 504;

Is rounding down to 500 an actual problem? Does it only make me feel better?

[Wenson Hsieh]

Comment on attachment 396439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396439&action=review

>> Source/WebCore/page/Quirks.cpp:760
>> +    return equalLettersIgnoringASCIICase(m_document->url().host(), "en.wikipedia.org");
> 
> You're missing like 160 subdomains

😅

(Will fix with "*.wikipedia.org" instead)

>> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:3892
>> +        return 504;
> 
> Is rounding down to 500 an actual problem? Does it only make me feel better?

500 will work too (I will tweak the above comment to say “close to” instead of “match”).

[Wenson Hsieh]

Created attachment 396445 [details]
Patch

[EWS]

Committed r260090: <https://trac.webkit.org/changeset/260090>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396445 [details].

Hi.

Please note that 319 *.wikipedia.org sites are not the only wikis operated under the Wikimedia umbrella. There are at least 600 wikis under other domains names, such as wikidata.org, mediawiki.org, *.wiktionary.org, *.wikivoyage.org and more (<https://www.wikimedia.org/>) that all operate from the same cluster with the same software and theme settings.

There are also many thousands more third-parties that self-host using the MediaWiki software (much like WordPress), with the same default theme.