Bug 210392

Summary: Make WTR::AccessibilityUIElements methods run on AX secondary thread.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: cfleizach, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Andres Gonzalez 2020-04-11 14:44:02 PDT
Make WTR::AccessibilityUIElements methods run on AX secondary thread.
Comment 1 Andres Gonzalez 2020-04-11 14:51:03 PDT
Created attachment 396192 [details]
Patch
Comment 2 chris fleizach 2020-04-11 17:56:38 PDT
GTK failures. looks like we have things like id in the .h file

../../Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:57:12: error: ‘id’ does not name a type; did you mean ‘GPid’?
     friend id attributeValue(id, NSString*);
            ^~
            GPid

../../Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp:29:
../../Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:56:12: error: ‘NSArray’ does not name a type; did you mean ‘GArray’?
     friend NSArray* supportedAttributes(id);
            ^~~~~~~
Comment 3 Andres Gonzalez 2020-04-13 06:55:29 PDT
Created attachment 396269 [details]
Patch
Comment 4 Andres Gonzalez 2020-04-13 06:57:56 PDT
(In reply to chris fleizach from comment #2)
> GTK failures. looks like we have things like id in the .h file
> 
> ../../Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:57:12:
> error: ‘id’ does not name a type; did you mean ‘GPid’?
>      friend id attributeValue(id, NSString*);
>             ^~
>             GPid
> 
> ../../Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp:29:
> ../../Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:56:12:
> error: ‘NSArray’ does not name a type; did you mean ‘GArray’?
>      friend NSArray* supportedAttributes(id);
>             ^~~~~~~

Fixed in latest revision.
Comment 5 chris fleizach 2020-04-13 10:01:06 PDT
Comment on attachment 396269 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396269&action=review

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:194
> +    for (NSUInteger i = 0; i < attributes.count; ++i) {

can we just do 
for (NSString *attribute in attributes) {
Comment 6 chris fleizach 2020-04-13 10:01:23 PDT
LGTM, but consider requests
Comment 7 EWS 2020-04-13 10:56:49 PDT
Committed r260029: <https://trac.webkit.org/changeset/260029>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396269 [details].
Comment 8 Radar WebKit Bug Importer 2020-04-13 10:57:17 PDT
<rdar://problem/61725588>