Bug 210334

Summary: [GTK4] Use ThemeAdwaita instead of ThemeGtk
Product: WebKit Reporter: Adrian Perez <aperez>
Component: WebKitGTKAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, cgarcia, csaavedra
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 210100    
Attachments:
Description Flags
Patch
none
Patch v2 none

Adrian Perez
Reported 2020-04-10 07:27:37 PDT
With GTK4 we cannot obtain the selection theme colors, so instead use ThemeAdwaita which uses the colors from the default theme used by GTK.
Attachments
Patch (2.53 KB, patch)
2020-04-10 07:32 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Patch v2 (3.33 KB, patch)
2020-04-13 10:31 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2020-04-10 07:32:04 PDT
Created attachment 396080 [details] Patch
Claudio Saavedra
Comment 2 2020-04-10 14:29:32 PDT
With GTK3 the selection colors are actually deprecated, so this is also a problem if we want to completely remove deprecated API usage. Do we want to continue using them?
Claudio Saavedra
Comment 3 2020-04-10 14:30:08 PDT
I meant the style context selection color APIs, for what it's worth.
Adrian Perez
Comment 4 2020-04-10 16:15:06 PDT
(In reply to Claudio Saavedra from comment #2) > With GTK3 the selection colors are actually deprecated, so this is also a > problem if we want to completely remove deprecated API usage. Do we want to > continue using them? Carlos Garcia specifically added ThemeGtk to have a minimum degree of integration with the system theme, so I think we should keep using it for now when building against GTK3.
Carlos Garcia Campos
Comment 5 2020-04-11 02:52:27 PDT
(In reply to Adrian Perez from comment #4) > (In reply to Claudio Saavedra from comment #2) > > With GTK3 the selection colors are actually deprecated, so this is also a > > problem if we want to completely remove deprecated API usage. Do we want to > > continue using them? > > Carlos Garcia specifically added ThemeGtk to have a minimum degree of > integration with the system theme, so I think we should keep using it > for now when building against GTK3. Yes, let's add deprecation guards if needed.
Adrian Perez
Comment 6 2020-04-13 10:31:45 PDT
Created attachment 396304 [details] Patch v2 Same as before, adding deprecation guards in ThemeGtk.cpp
EWS
Comment 7 2020-04-13 22:13:04 PDT
Committed r260058: <https://trac.webkit.org/changeset/260058> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396304 [details].
Note You need to log in before you can comment on or make changes to this bug.