Bug 21031 – Breakpoints in the condition of loops only breaks the first time

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Kevin McCullough]

While you can break in a loop or on the conditional line (the line with "for", "while" etc), you can only break on the conditional line the first time

* STEPS TO REPRODUCE
1. Open the attached testcase
2. Open the inspector and set a breakpoint on a line that has a conditional (like a for or while loop)
3. Click on the link
4. You'll hit the breakpoint.  Then hit continue.  This will run the JS without hitting the breakpoint again.

<rdar://problem/6204189>

[Kevin McCullough]

Created attachment 23711 [details]
Test case

[Kevin McCullough]

Created attachment 23723 [details]
Patch

[Geoffrey Garen]

Comment on attachment 23723 [details]
Patch

r=me, with changes we wrote on your computer.

[Kevin McCullough]

Created attachment 23763 [details]
Proposed patch

Because of some changes wrt 'for' loops I've asked for another review.

[Geoffrey Garen]

     if (!m_statement->isBlock())
         generator.emitDebugHook(WillExecuteStatement, m_statement->firstLine(), m_statement->lastLine());

I just realized a lingering problem from the last time I reviewed this. Cases like the line above are wrong for loops. If you have

do {
    do {
    } while(y);
} while(x);

The outer do will emit a debug hook for the inner do, then the inner do will emit a debug hook for itself. So, if you set a breakpoint on the inner do, it will be hit twice.

I think you need to change this to "if (!m_statement->isBlock() && !m_statement->isLoop())".

r=me with that change.

[Geoffrey Garen]

Comment on attachment 23763 [details]
Proposed patch

r=me

[Kevin McCullough]

Committed revision 36871.