|Summary:||Add support for the Wasm i32 sign-extension-ops proposal|
|Product:||WebKit||Reporter:||Ben Smith <binji>|
|Component:||WebAssembly||Assignee:||Sergey Rubanov <chi187>|
|Severity:||Normal||CC:||chi187, cryze92, dschuff, ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, sbarati, tzagallo, webkit-bug-importer, ysuzuki|
Description Ben Smith 2020-04-09 13:28:26 PDT
The sign-extension-ops proposal recently became standardized as a phase 5 proposal, and was merged into the spec repo: https://github.com/WebAssembly/spec/pull/1144
Comment 2 Keith Miller 2020-04-09 17:10:15 PDT
Yikes! We never did this? Whoops... Thanks for the report!
Comment 4 EWS Watchlist 2020-11-14 13:52:05 PST
Comment 5 Sergey Rubanov 2020-11-14 13:53:11 PST
This patch implements only sign extensions to i32 for now. It passes spect tests from https://bugs.webkit.org/show_bug.cgi?id=218940 i62 is WIP
Comment 11 Yusuke Suzuki 2020-11-16 08:43:05 PST
Comment 13 Sergey Rubanov 2020-11-16 09:11:47 PST
Bug for i64 sign-extension-ops proposal https://bugs.webkit.org/show_bug.cgi?id=218990
Comment 15 Yusuke Suzuki 2020-11-16 09:34:29 PST
Comment on attachment 414242 [details] Patch OK, for GTK and WPE builds, I ensured that GTK / WPE build work on my Linux (Debian unstable) box, so I think this is build-related stale, and clean-build will fix the issue. And we know that the code in this patch is not changed from r+ patch. I'll put cq+ here.
Comment 16 EWS 2020-11-16 09:35:01 PST
ChangeLog entry in JSTests/ChangeLog contains OOPS!.