Summary: | Add support for the Wasm i32 sign-extension-ops proposal | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ben Smith <binji> | ||||||||||||||||||||
Component: | WebAssembly | Assignee: | Sergey Rubanov <chi187> | ||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||
Severity: | Normal | CC: | chi187, cryze92, dschuff, ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||
Version: | Other | ||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=218990 | ||||||||||||||||||||||
Attachments: |
|
Description
Ben Smith
2020-04-09 13:28:26 PDT
Yikes! We never did this? Whoops... Thanks for the report! Created attachment 414143 [details]
Patch
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json". This patch implements only sign extensions to i32 for now. It passes spect tests from https://bugs.webkit.org/show_bug.cgi?id=218940 i62 is WIP Created attachment 414145 [details]
Patch
Created attachment 414147 [details]
Patch
Created attachment 414148 [details]
Patch
Created attachment 414150 [details]
Patch
Created attachment 414173 [details]
Patch
Comment on attachment 414173 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414173&action=review r=me Nice. > Source/JavaScriptCore/ChangeLog:3 > + Add support for the Wasm sign-extension-ops proposal Can you change the bug title + ChangeLog titles to clarify this implements i32 sign-extension-ops and it is not including i64 ops? And, can you open a bug for i64 sign-extension-ops, and change JSTests/wasm/spec-tests/i64.wast.js's URL to the new one? Created attachment 414239 [details]
Patch
Bug for i64 sign-extension-ops proposal https://bugs.webkit.org/show_bug.cgi?id=218990 Created attachment 414242 [details]
Patch
Comment on attachment 414242 [details]
Patch
OK, for GTK and WPE builds, I ensured that GTK / WPE build work on my Linux (Debian unstable) box, so I think this is build-related stale, and clean-build will fix the issue.
And we know that the code in this patch is not changed from r+ patch. I'll put cq+ here.
ChangeLog entry in JSTests/ChangeLog contains OOPS!. Created attachment 414245 [details]
Patch
Committed r269929: <https://trac.webkit.org/changeset/269929> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414245 [details]. |