Bug 210224

Summary: Handle [PDFDocument initWithProvider:] returning nil
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ggaren: review+
Patch none

Brady Eidson
Reported 2020-04-08 16:03:40 PDT
Handle [PDFDocument initWithProvider:] returning nil <rdar://problem/61482395>
Attachments
Patch (1.60 KB, patch)
2020-04-08 16:07 PDT, Brady Eidson 		ggaren: review+
DetailsFormatted DiffDiff
Patch (1.57 KB, patch)
2020-04-08 16:16 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2020-04-08 16:07:36 PDT
Created attachment 395880 [details] Patch
Geoffrey Garen
Comment 2 2020-04-08 16:10:07 PDT
Comment on attachment 395880 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395880&action=review r=me > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:873 > + if (!m_incrementalPDFLoadingEnabled || !m_backgroundThreadDocument) { > m_backgroundThreadDocument = nil; You could just do a separate early return, since it's kinda silly to say "if m_backgroundThreadDocument is null, set m_backgroundThreadDocument to null".
Brady Eidson
Comment 3 2020-04-08 16:16:14 PDT
Created attachment 395882 [details] Patch
EWS
Comment 4 2020-04-08 16:50:44 PDT
Committed r259765: <https://trac.webkit.org/changeset/259765> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395882 [details].
Radar WebKit Bug Importer
Comment 5 2020-04-08 16:51:15 PDT
<rdar://problem/61485477>
Note You need to log in before you can comment on or make changes to this bug.