Bug 210224

Summary:

Handle [PDFDocument initWithProvider:] returning nil

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebKit Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ggaren, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ggaren: review+
Patch	none

Description Brady Eidson 2020-04-08 16:03:40 PDT

Handle [PDFDocument initWithProvider:] returning nil

<rdar://problem/61482395>

Comment 1 Brady Eidson 2020-04-08 16:07:36 PDT

Created attachment 395880 [details]
Patch

Comment 2 Geoffrey Garen 2020-04-08 16:10:07 PDT

Comment on attachment 395880 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395880&action=review

r=me

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:873
> +    if (!m_incrementalPDFLoadingEnabled || !m_backgroundThreadDocument) {
>          m_backgroundThreadDocument = nil;

You could just do a separate early return, since it's kinda silly to say "if m_backgroundThreadDocument is null, set m_backgroundThreadDocument to null".

Comment 3 Brady Eidson 2020-04-08 16:16:14 PDT

Created attachment 395882 [details]
Patch

Comment 4 EWS 2020-04-08 16:50:44 PDT

Committed r259765: <https://trac.webkit.org/changeset/259765>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395882 [details].

Comment 5 Radar WebKit Bug Importer 2020-04-08 16:51:15 PDT

<rdar://problem/61485477>