Bug 21022
| Summary: | bugs.webkit.org should discourage patches larger than 20k (or some arbitrary size) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | WebKit Website | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | anitriaa44 |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
Eric Seidel (no email)
bugs.webkit.org should discourage patches larger than 20k (or some arbitrary size)
I think our tools could assist us here. I think it could be helpful towards education of contributers, and towards sanity of reviewers, if bugs.webkit.org would display some sort of warning page when you tried to upload a patch which was larger than 50k/20k or some arbitrary size. Especially when non-committers or first-time contributers upload 100k patches, its just a waste of reviewers time and their time, trying to fight it down to something that's more reviewable. I don't think technology is the final solution to that problem, but making it clear during the patch upload process that your patch exceeds the "sane" size limit, could be useful.
Heck there are other things bugzilla (or other scripts/tools) could scan for, like lack of ChangeLog too... but that's the subject for another bug.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
anitria
(In reply to comment #0)
> bugs.webkit.org should discourage patches larger than 20k (or some arbitrary size)
>
> I think our tools could assist us here. I think it could be helpful towards education of contributers, and towards sanity of reviewers, if bugs.webkit.org would display some sort of warning page when you tried to upload a patch which was larger than 50k/20k or some arbitrary size. Especially when non-committers or first-time contributers upload 100k patches, its just a waste of reviewers time and their time, trying to fight it down to something that's more reviewable. I don't think technology is the final solution to that problem, but making it clear during the patch upload process that your patch exceeds the "sane" size limit, could be useful.
>
> Heck there are other things bugzilla (or other scripts/tools) could scan for, like lack of ChangeLog too... but that's the subject for another bug.
Alexey Proskuryakov
svn-create-patch has the warning. Eric, is this still something that needs to be looked into?