Bug 210132

Summary:

[CMake] Use WEBKIT_EXECUTABLE in WebKitTestRunner

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

CMake

Assignee:

Don Olmstead <don.olmstead>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, aperez, benjamin, cdumez, cmarcelo, ews-watchlist, fujii.hironori, gyuyoung.kim, keith_miller, mark.lam, mcatanzaro, msaboff, ross.kirsling, ryuan.choi, saam, sergio, tzagallo

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP Patch	none
WIP Patch	none
Patch	aperez: review+
Patch	none
Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
Patch	none

Don Olmstead

Reported 2020-04-07 10:41:31 PDT

...

Attachments
WIP Patch (23.75 KB, patch) 2020-04-07 10:42 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (24.45 KB, patch) 2020-04-07 10:57 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
Patch (25.64 KB, patch) 2020-04-07 11:43 PDT, Don Olmstead	aperez: review+	Details Formatted Diff Diff
Patch (24.79 KB, patch) 2020-04-08 10:47 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
Patch (24.79 KB, patch) 2020-04-08 10:53 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (8.37 KB, patch) 2020-04-10 21:53 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (4.25 KB, patch) 2020-04-22 13:22 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (29.52 KB, patch) 2020-04-22 14:41 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (29.57 KB, patch) 2020-04-22 14:54 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
Patch (24.90 KB, patch) 2020-04-22 15:26 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Don Olmstead

Comment 1 2020-04-07 10:42:22 PDT Comment hidden (obsolete)

Created attachment 395706 [details] WIP Patch

Don Olmstead

Comment 2 2020-04-07 10:57:51 PDT Comment hidden (obsolete)

Created attachment 395708 [details] WIP Patch

Don Olmstead

Comment 3 2020-04-07 11:43:29 PDT

Created attachment 395715 [details] Patch

Adrian Perez

Comment 4 2020-04-07 14:00:25 PDT

Comment on attachment 395715 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395715&action=review Simplifications are always welcome :] > Tools/WebKitTestRunner/CMakeLists.txt:34 > + ${CMAKE_BINARY_DIR} Just wondering… it seems quite common to add ${CMAKE_BINARY_DIR} as one of the include directories, so maybe it would make sense to always add it in the _WEBKIT_TARGET() macro. WDYT?

Fujii Hironori

Comment 5 2020-04-07 14:11:05 PDT

Comment on attachment 395715 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395715&action=review > Tools/WebKitTestRunner/CMakeLists.txt:16 > + CyclicRedundancyCheck.cpp You replaced ${WEBKIT_TESTRUNNER_DIR}/CyclicRedundancyCheck.cpp with CyclicRedundancyCheck.cpp by removing ${WEBKIT_TESTRUNNER_DIR}. This change looks good. You should do that more. > Tools/WebKitTestRunner/CMakeLists.txt:60 > + ${WebKitTestRunner_INJECTEDBUNDLE_DIR}/TextInputController.cpp Replace ${WebKitTestRunner_INJECTEDBUNDLE_DIR}/TextInputController.cpp with InjectedBundle/TextInputController.cpp.

Don Olmstead

Comment 6 2020-04-08 10:47:04 PDT

Created attachment 395833 [details] Patch

Don Olmstead

Comment 7 2020-04-08 10:53:01 PDT

Created attachment 395835 [details] Patch

Don Olmstead

Comment 8 2020-04-10 21:53:33 PDT

Created attachment 396149 [details] WIP Patch

Adrian Perez

Comment 9 2020-04-15 07:08:46 PDT

The failures from the GTK/EWS bots seem to be caused by the compiler not being able to find the “cmakeconfig.h” file , so we would need to add ${CMAKE_BINARY_DIR} to the list of include directories for the different targets. Would it make sense to have the _WEBKIT_TARGET() always add implicitly ${CMAKE_BINARY_DIR} as an include directory for the targets it creates?

Don Olmstead

Comment 10 2020-04-22 13:22:34 PDT

Created attachment 397245 [details] WIP Patch

Don Olmstead

Comment 11 2020-04-22 14:41:32 PDT

Created attachment 397263 [details] WIP Patch

Don Olmstead

Comment 12 2020-04-22 14:54:09 PDT

Created attachment 397266 [details] WIP Patch

Don Olmstead

Comment 13 2020-04-22 15:26:54 PDT

Created attachment 397275 [details] Patch

EWS

Comment 14 2020-04-22 16:41:42 PDT

Committed r260539: <https://trac.webkit.org/changeset/260539> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397275 [details].

Note You need to log in before you can comment on or make changes to this bug.