Bug 210052

Summary: Make sure playback of remote audio tracks is stable even if pages are using webaudio
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, peng.liu6, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Alternative Fix
none
Patch none

Description youenn fablet 2020-04-06 09:24:04 PDT 
Make sure playback of remote audio track is stable even if pages are using webaudio
Comment 1 youenn fablet 2020-04-06 10:46:50 PDT 
Created attachment 395585 [details]
Patch
Comment 2 youenn fablet 2020-04-06 11:17:49 PDT 
Created attachment 395590 [details]
Patch
Comment 3 Jer Noble 2020-04-06 14:53:01 PDT 
Comment on attachment 395590 [details]
Patch

I think this attachment was for a different bug (#210044).
Comment 4 Jer Noble 2020-04-06 14:59:06 PDT 
Created attachment 395621 [details]
Alternative Fix
Comment 5 youenn fablet 2020-04-07 04:23:38 PDT 
Created attachment 395668 [details]
Patch
Comment 6 Jer Noble 2020-04-07 10:24:20 PDT 
Comment on attachment 395621 [details]
Alternative Fix

This fixes one class of dropout bugs when sending audio from WebRTC through WebAudio, but does not fix everything. Regardless, we should land this and follow up with more fixes.
Comment 7 EWS 2020-04-07 10:26:45 PDT 
Committed r259644: <https://trac.webkit.org/changeset/259644>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395621 [details].
Comment 8 Radar WebKit Bug Importer 2020-04-07 10:27:16 PDT 
<rdar://problem/61398793>