Bug 21005

Summary:

Scope the Inspector's search field to the current panel

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector (Deprecated)

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

aroben, kmccullough

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Searching in Elements	none
Searching in Resources	none
Search in Scripts	none
Search in Profiles	none
Remove previous search code	oliver: review+
Proposed patch	oliver: review+
Add support to Panel	oliver: review+
Highlight the search results in the Elements panel	oliver: review+
Rename some properties	oliver: review+
Adds search support to the Resources and Scripts panels	oliver: review+
Adds search support to the Profiles panel	oliver: review+

Timothy Hatcher

Reported 2008-09-22 13:32:35 PDT

The Inspector's search should happen on the current panel and not be global. This would help speed things up by limiting what is searched, and it would improve the usefulness and interface.

Attachments
Searching in Elements (223.53 KB, image/png) 2008-09-22 13:33 PDT, Timothy Hatcher	no flags	Details
Searching in Resources (159.73 KB, image/png) 2008-09-22 13:33 PDT, Timothy Hatcher	no flags	Details
Search in Scripts (106.50 KB, image/png) 2008-09-22 13:35 PDT, Timothy Hatcher	no flags	Details
Search in Profiles (167.29 KB, image/png) 2008-09-23 13:14 PDT, Timothy Hatcher	no flags	Details
Remove previous search code (17.26 KB, patch) 2008-09-23 13:54 PDT, Timothy Hatcher	oliver: review+	Details Formatted Diff Diff
Proposed patch (16.30 KB, patch) 2008-09-23 14:13 PDT, Timothy Hatcher	oliver: review+	Details Formatted Diff Diff
Add support to Panel (9.67 KB, patch) 2008-09-23 14:23 PDT, Timothy Hatcher	oliver: review+	Details Formatted Diff Diff
Highlight the search results in the Elements panel (7.06 KB, patch) 2008-09-23 14:35 PDT, Timothy Hatcher	oliver: review+	Details Formatted Diff Diff
Rename some properties (7.84 KB, patch) 2008-09-23 14:37 PDT, Timothy Hatcher	oliver: review+	Details Formatted Diff Diff
Adds search support to the Resources and Scripts panels (55.85 KB, patch) 2008-09-23 15:01 PDT, Timothy Hatcher	oliver: review+	Details Formatted Diff Diff
Adds search support to the Profiles panel (24.65 KB, patch) 2008-09-23 15:24 PDT, Timothy Hatcher	oliver: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2008-09-22 13:33:10 PDT

Created attachment 23662 [details] Searching in Elements

Timothy Hatcher

Comment 2 2008-09-22 13:33:41 PDT

Created attachment 23663 [details] Searching in Resources

Timothy Hatcher

Comment 3 2008-09-22 13:35:23 PDT

Created attachment 23664 [details] Search in Scripts

Timothy Hatcher

Comment 4 2008-09-23 13:14:37 PDT

Created attachment 23713 [details] Search in Profiles

Timothy Hatcher

Comment 5 2008-09-23 13:54:18 PDT

Created attachment 23720 [details] Remove previous search code

Timothy Hatcher

Comment 6 2008-09-23 14:13:19 PDT

Created attachment 23724 [details] Proposed patch

Timothy Hatcher

Comment 7 2008-09-23 14:23:05 PDT

Created attachment 23725 [details] Add support to Panel

Timothy Hatcher

Comment 8 2008-09-23 14:35:03 PDT

Created attachment 23726 [details] Highlight the search results in the Elements panel

Timothy Hatcher

Comment 9 2008-09-23 14:37:36 PDT

Created attachment 23727 [details] Rename some properties

Timothy Hatcher

Comment 10 2008-09-23 15:01:12 PDT

Created attachment 23730 [details] Adds search support to the Resources and Scripts panels

Timothy Hatcher

Comment 11 2008-09-23 15:24:29 PDT

Created attachment 23732 [details] Adds search support to the Profiles panel

Oliver Hunt

Comment 12 2008-09-23 16:43:03 PDT

Comment on attachment 23732 [details] Adds search support to the Profiles panel s/Greather/Greater in the changelog

Timothy Hatcher

Comment 13 2008-09-23 19:13:08 PDT

Landed in r36830-36837.

Note You need to log in before you can comment on or make changes to this bug.