| Summary: | 'currentcolor' doesn't need setHasExplicitlyInheritedProperties marking anymore | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||||||||
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, pdr, simon.fraser, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=193171 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Antti Koivisto
2020-04-04 22:13:06 PDT
Created attachment 395482 [details]
patch
Created attachment 395497 [details]
wip
Created attachment 395555 [details]
patch
Created attachment 395556 [details]
patch
Created attachment 395579 [details]
patch
Comment on attachment 395579 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=395579&action=review > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2169 > + // While most color properties are not inherited the value 'currentcolor' resolves to the value of the inherited 'color' property. Needs a comma after the word "inherited". > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2200 > + for (size_t i = 0; i < shorthand.length(); ++i) { > + if (!hasValidStyleForProperty(element, shorthand.properties()[i])) > + return false; > + } Seems like StylePropertyShorthand could use a way to use a for loop without writing it out. Since length() returns unsigned it’s not clear it’s helpful to use size_t for the loop, but that question only arises because we can’t use a modern for loop. Wish the standard library offered a way to return a pointer and length as a for-loop-compatible range. I’m sure it’s coming in C++20. > Seems like StylePropertyShorthand could use a way to use a for loop without
> writing it out. Since length() returns unsigned it’s not clear it’s helpful
> to use size_t for the loop, but that question only arises because we can’t
> use a modern for loop.
Yeah, noticed that too. I'll fix it separately.
Created attachment 395586 [details]
patch
Committed r259585: <https://trac.webkit.org/changeset/259585> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395586 [details]. |