Bug 210007

Summary: Remove LockHistory parameter from loadWithNavigationAction
Product: WebKit Reporter: Rob Buis <rbuis>
Component: New BugsAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, ews-watchlist, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Rob Buis
Reported 2020-04-04 10:28:28 PDT
Remove LockHistory parameter from loadWithNavigationAction since NavigationAction has a member for this. Where needed explicitly set the LockHistory on the actions.
Attachments
Patch (8.31 KB, patch)
2020-04-04 10:30 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-04-04 10:30:18 PDT
Created attachment 395456 [details] Patch
Darin Adler
Comment 2 2020-04-04 16:27:14 PDT
Comment on attachment 395456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395456&action=review > Source/WebCore/loader/FrameLoader.cpp:1424 > - loadWithNavigationAction(request, WTFMove(action), lockHistory, newLoadType, WTFMove(formState), allowNavigationToInvalidURL, frameLoadRequest.downloadAttribute(), [this, isRedirect, sameURL, newLoadType, protectedFrame = makeRef(m_frame), completionHandler = completionHandlerCaller.release()] () mutable { > + loadWithNavigationAction(request, WTFMove(action), newLoadType, WTFMove(formState), allowNavigationToInvalidURL, frameLoadRequest.downloadAttribute(), [this, isRedirect, sameURL, newLoadType, protectedFrame = makeRef(m_frame), completionHandler = completionHandlerCaller.release()] () mutable { How did you determine that it’s not necessary to call setLockHistory on the action here, the way you did in FrameLoader::loadWithNavigationAction?
Darin Adler
Comment 3 2020-04-04 16:27:44 PDT
Comment on attachment 395456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395456&action=review >> Source/WebCore/loader/FrameLoader.cpp:1424 >> + loadWithNavigationAction(request, WTFMove(action), newLoadType, WTFMove(formState), allowNavigationToInvalidURL, frameLoadRequest.downloadAttribute(), [this, isRedirect, sameURL, newLoadType, protectedFrame = makeRef(m_frame), completionHandler = completionHandlerCaller.release()] () mutable { > > How did you determine that it’s not necessary to call setLockHistory on the action here, the way you did in FrameLoader::loadWithNavigationAction? Oh, I see now. It’s already done above.
EWS
Comment 4 2020-04-04 22:09:48 PDT
Committed r259544: <https://trac.webkit.org/changeset/259544> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395456 [details].
Radar WebKit Bug Importer
Comment 5 2020-04-04 22:10:15 PDT
<rdar://problem/61308935>
Note You need to log in before you can comment on or make changes to this bug.