Bug 209913

Summary:

Computed style for "outline-offset" is wrong when "outline-style" is "none"

Product:

WebKit

Reporter:

Manuel Rego Casasnovas <rego>

Component:

CSS

Assignee:

Manuel Rego Casasnovas <rego>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.chromium.org/p/chromium/issues/detail?id=1005372

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Manuel Rego Casasnovas

Reported 2020-04-02 09:45:10 PDT

This is easy to reproduce with the following example: <style>#foo { outline-offset: 10px; }</style> <div id="foo"></div> <script>console.log(getComputedStyle(foo).outlineOffset);</script> It should log 10px but it actually logs 0px. This is probably a mistake as "outline-width" is special on the spec (https://drafts.csswg.org/css-ui/#outline-props). For "outline-width" the computed value says: "absolute length; 0 if the outline style is none." But for "outline-offset" it says: "absolute length" There's a check causing this behavior at RenderStyle::outlineOffset().

Attachments
Patch (5.97 KB, patch) 2020-04-02 22:05 PDT, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Patch (17.79 KB, patch) 2020-04-03 02:27 PDT, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Patch (17.79 KB, patch) 2020-04-03 02:55 PDT, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.