Summary: | Default link colors lack sufficient contrast in the dark color scheme | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Thomas Steiner <tomac> | ||||
Component: | CSS | Assignee: | Aditya Keerthi <akeerthi> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | akeerthi, argyle, contact+bugs.webkit.org, dev.connor25, mail, martin, miriam, ntim, robin, sam, simon.fraser, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Safari Technology Preview | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=235332 | ||||||
Attachments: |
|
Description
Thomas Steiner
2020-04-01 03:00:34 PDT
Since this probably requires changes to the user agent stylesheets, it would be great to agree on a cross-browser set of dark scheme default link colors. [Chrome](https://crbug.com/1066811) [WebKit](https://bugs.webkit.org/show_bug.cgi?id=209851) [Firefox](https://bugzilla.mozilla.org/show_bug.cgi?id=1626560) I have opened https://github.com/whatwg/html/issues/5426 for cross-vendor awareness. *** Bug 226893 has been marked as a duplicate of this bug. *** *** Bug 235328 has been marked as a duplicate of this bug. *** I don’t think this is as simple as just updating the color in `RenderTheme.cpp`, I believe there is also logic on `Document.cpp` to support the `link` attribute that needs to be reworked. Are there any plans/relative priorities for fixing this? For a blog website, simply using `color-scheme: light dark` has a lot of benefits. Firefox and Chrome have fixed their link colors in `color-scheme: dark` (on macOS/desktop at least), so I hope to see Safari support land. Pull request: https://github.com/WebKit/WebKit/pull/17512 Committed 267847@main (5413aa7d4157): <https://commits.webkit.org/267847@main> Reviewed commits have been landed. Closing PR #17512 and removing active labels. |