Summary: | REGRESSION (r251574, r251600): _WKTextManipulationToken and _WKTextManipulationConfiguration are missing -dealloc | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Component: | WebKit2 | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | rniwa, webkit-bug-importer, wenson_hsieh | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2020-03-30 20:06:26 PDT
Created attachment 395011 [details]
Patch v1
Comment on attachment 395011 [details]
Patch v1
We usually solve this problem with RetainPtr, but this works too.
(In reply to Wenson Hsieh from comment #3) > Comment on attachment 395011 [details] > Patch v1 > > We usually solve this problem with RetainPtr, but this works too. After we switch to compiling with ARC, won't we just de-RetainPtr<> the class again because it's no longer necessary? Committed r259280: <https://trac.webkit.org/changeset/259280> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395011 [details]. |