Bug 209787

Summary:

[Cocoa] UTI from MIME type cache can be removed after r258915

Product:

WebKit

Reporter:

Per Arne Vollan <pvollan>

Component:

WebKit Misc.

Assignee:

Per Arne Vollan <pvollan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, bfulgham, cdumez, cmarcelo, ews-watchlist, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Per Arne Vollan

Reported 2020-03-30 15:59:49 PDT

In <https://trac.webkit.org/changeset/257828>, a UTI from MIME type cache was added to avoid connecting to a launch services daemon in the WebContent process, but after <https://trac.webkit.org/changeset/258915> this cache is not strictly needed anymore, since <https://trac.webkit.org/changeset/258915> solves the problem of avoiding to connect to the daemon in a general way.

Attachments
Patch (8.95 KB, patch) 2020-03-30 16:23 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (18.01 KB, patch) 2020-04-01 06:36 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (18.06 KB, patch) 2020-04-01 13:04 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (18.22 KB, patch) 2020-04-01 16:54 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Per Arne Vollan

Comment 1 2020-03-30 16:00:37 PDT

rdar://problem/60714318

Per Arne Vollan

Comment 2 2020-03-30 16:23:00 PDT

Created attachment 394981 [details] Patch

Tim Horton

Comment 3 2020-03-30 16:28:44 PDT

Comment on attachment 394981 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394981&action=review > Source/WebCore/ChangeLog:14 > + using this cache could possibly be a performance progression if it's done the right way. This investigation > + will be done at a later time. Instead of this, let's just delete the code. It will always live in SVN history if at a later time we want to revive it for the performance progression. We don't tend to keep code in WebKit that is not compiled on any port, because it just rots and causes confusion.

Per Arne Vollan

Comment 4 2020-03-30 16:39:43 PDT

(In reply to Tim Horton from comment #3) > Comment on attachment 394981 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=394981&action=review > > > Source/WebCore/ChangeLog:14 > > + using this cache could possibly be a performance progression if it's done the right way. This investigation > > + will be done at a later time. > > Instead of this, let's just delete the code. It will always live in SVN > history if at a later time we want to revive it for the performance > progression. We don't tend to keep code in WebKit that is not compiled on > any port, because it just rots and causes confusion. Sounds good! I will delete the code in the upcoming patch. Thanks for reviewing!

Per Arne Vollan

Comment 5 2020-04-01 06:36:08 PDT

Created attachment 395160 [details] Patch

Per Arne Vollan

Comment 6 2020-04-01 13:04:49 PDT

Created attachment 395195 [details] Patch

EWS

Comment 7 2020-04-01 16:31:06 PDT

Attachment 395195 [details] does not apply

Per Arne Vollan

Comment 8 2020-04-01 16:54:16 PDT

Created attachment 395227 [details] Patch

EWS

Comment 9 2020-04-01 17:20:00 PDT

Committed r259374: <https://trac.webkit.org/changeset/259374> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395227 [details].

Note You need to log in before you can comment on or make changes to this bug.