| Summary: | [Qt] SVG patterns are missing | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Schulze <krit> | ||||||
| Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | Keywords: | Qt | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Dirk Schulze
2008-09-21 11:33:16 PDT
Created attachment 23629 [details]
SVGPattern
This patch adds svg pattern support. Only texts are not supported (like on gradients).
Comment on attachment 23629 [details] SVGPattern + PassRefPtr<Pattern> pattern; + pattern = Pattern::create(tile()->image(), true, true); This is an inefficient idiom. It's more efficient to initialize on the same line the variable is defined on. But also the local variable should be RefPtr, not PassRefPtr. See <http://webkit.org/coding/RefPtr.html> for guidelines. + QBrush brush(pattern.get()->createPlatformPattern(affine)); No need for the call to get() here. You can just use the -> operator normally with smart pointers. r=me as-is, but I suggest making those two refinements. Created attachment 23651 [details]
SVGPattern
Forgot to add QPainter and changed PassRefPtr to RefPtr.
Comment on attachment 23651 [details]
SVGPattern
r=me
|