Summary: | Regression(r259034): UniqueIDBDatabas object is destroyed while it's still in use | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sihui Liu <sihui_liu> | ||||
Component: | New Bugs | Assignee: | Sihui Liu <sihui_liu> | ||||
Status: | RESOLVED INVALID | ||||||
Severity: | Normal | CC: | alecflett, beidson, ews-watchlist, ggaren, jsbell, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Sihui Liu
2020-03-28 00:07:58 PDT
Created attachment 394794 [details]
Patch
Comment on attachment 394794 [details]
Patch
It would be nice to figure out how to use smart pointers to ensure memory safety here; smart pointers are much easier to get right.
(In reply to Geoffrey Garen from comment #3) > Comment on attachment 394794 [details] > Patch > > It would be nice to figure out how to use smart pointers to ensure memory > safety here; smart pointers are much easier to get right. Yes, will try replacing the raw pointers and remove unnecessary protected pointers to make the ownership clearer. Since r259034 is reverted and this patch works as an alternative, I will move this patch to https://bugs.webkit.org/show_bug.cgi?id=209532 and land it from there. |