Bug 209690 – Skip stress/test-out-of-memory.js on memory limited devices.

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Mark Lam]

<rdar://problem/60659198>

[Mark Lam]

Created attachment 394773 [details]
proposed patch.

[Keith Miller]

Comment on attachment 394773 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=394773&action=review

> JSTests/stress/test-out-of-memory.js:1
> +//@ skip if $memoryLimited or ["arm", "mips"].include?($architecture)

I think $memoryLimited is a superset of "arm"/"mips"?

[Mark Lam]

(In reply to Keith Miller from comment #2)
> Comment on attachment 394773 [details]
> proposed patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=394773&action=review
> 
> > JSTests/stress/test-out-of-memory.js:1
> > +//@ skip if $memoryLimited or ["arm", "mips"].include?($architecture)
> 
> I think $memoryLimited is a superset of "arm"/"mips"?

I think you're right, but I don't see code that confirms this for sure.  This change is conservative.  I would like to land it to green a bot, and I'll ping the arm/mips guys to remove the condition if it is indeed unnecessary.

[Keith Miller]

Comment on attachment 394773 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=394773&action=review

r=me.

>>> JSTests/stress/test-out-of-memory.js:1
>>> +//@ skip if $memoryLimited or ["arm", "mips"].include?($architecture)
>> 
>> I think $memoryLimited is a superset of "arm"/"mips"?
> 
> I think you're right, but I don't see code that confirms this for sure.  This change is conservative.  I would like to land it to green a bot, and I'll ping the arm/mips guys to remove the condition if it is indeed unnecessary.

sounds good. Can you make sure to ping them?

[Mark Lam]

Thanks.  Landed in r259149: <http://trac.webkit.org/r259149>.

[Caio Lima]

Comment on attachment 394773 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=394773&action=review

>>>> JSTests/stress/test-out-of-memory.js:1
>>>> +//@ skip if $memoryLimited or ["arm", "mips"].include?($architecture)
>>> 
>>> I think $memoryLimited is a superset of "arm"/"mips"?
>> 
>> I think you're right, but I don't see code that confirms this for sure.  This change is conservative.  I would like to land it to green a bot, and I'll ping the arm/mips guys to remove the condition if it is indeed unnecessary.
> 
> sounds good. Can you make sure to ping them?

Just for the record, `$memoryLimited` and `$architecture == "arm" or "mips"`are note related each other. However, we use `--memory-limited` to run stress tests in all bots for ARMv7 and MIPS. Since it is defined in bots configuration, I'm afraid we won't find any relationship of them on WebKit tree. I think it is fine to have a mental model that `$memoryLimited is a superset of "arm"/"mips"` now, but It can change in the future.