Bug 209562 – results.webkit.org: Add investigation endpoint

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Jonathan Bedard]

We should have a place which links all failures for a specific commit or range of commits. This is essentially a visualization of the /api/failures endpoint, which will tell us which tests failed on a given configuration/uuid.

[Jonathan Bedard]

Created attachment 394548 [details]
Patch

[Jonathan Bedard]

Created attachment 395102 [details]
Patch

[Jonathan Bedard]

Created attachment 395232 [details]
Patch

[Zhifei Fang]

Comment on attachment 395232 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395232&action=review

> Tools/resultsdbpy/resultsdbpy/view/static/js/common.js:188
> +    result += `${time.getSeconds() <= 9 && time.getMinutes() ? '0' : ''}${time.getSeconds()}.${time.getMilliseconds() <= 99 ? '0' : ''}${time.getMilliseconds() <= 9 ? '0' : ''}${time.getMilliseconds()} `;

instead of showing things like "Suite took 22:37.856 minutes to run" I think it will be better to change "Suite took 22 minutes and 37.856 seconds to run"

> Tools/resultsdbpy/resultsdbpy/view/templates/investigate.html:116
> +                            <div class="item text block" style="width: 100%; overflow: hidden; white-space: nowrap; text-overflow: ellipsis;">${diff.configuration}</div>

I guess we may need to consider to add a prefix "Configuration" here to explain what's this, especially for "all" configuration.

> Tools/resultsdbpy/resultsdbpy/view/templates/investigate.html:118
> +                                Comprised of ${diff.results.length} run${diff.results.length === 1 ? '' : 's'} using

I guess for a single run result , maybe we change this to fit it only show one run result, like "revision: ${}" since we are not aggregating anything, and maybe we should display the commit pair instead

> Tools/resultsdbpy/resultsdbpy/view/templates/investigate.html:131
> +                                        return 'unknown commits';

Not sure if those results are still worth to show, since we cannot locate them, then we cannot compare them, we just know there is a failure. or maybe we just don't have enough data in the commit database currently, maybe it will later have enough info to display ?

> Tools/resultsdbpy/resultsdbpy/view/templates/investigate.html:173
> +                            <div class="col-s-6 list">

Should we add a title here to explain what's the list for? I guess we are trying to display all the failed test runs here.

> Tools/resultsdbpy/resultsdbpy/view/templates/investigate.html:214
> +                DOM.inject(element, `<div class="list">

Should we also consider add a title to explain this list here ? I guess we are displaying the specific failed tests here.

> Tools/resultsdbpy/resultsdbpy/view/templates/investigate.html:370
> +                            <a class="button" style="cursor: pointer; display: none" ref="${this.previous}">â Previous</a>

Maybe a drop down will be more useful here, consider the user may want to see an overview, and jump between them

[Jonathan Bedard]

Created attachment 397269 [details]
Patch

[Aakash Jain]

rs=me

[Jonathan Bedard]

Created attachment 397722 [details]
Patch

[EWS]

Committed r260782: <https://trac.webkit.org/changeset/260782>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397722 [details].

[Radar WebKit Bug Importer]

<rdar://problem/62468215>