Bug 209532

Summary:

IndexedDB: destroy UniqueIDBDatabase when it's not used

Product:

WebKit

Reporter:

Sihui Liu <sihui_liu>

Component:

WebCore Misc.

Assignee:

Sihui Liu <sihui_liu>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, beidson, commit-queue, ews-watchlist, ggaren, jsbell, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

209700

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none

Sihui Liu

Reported 2020-03-24 22:58:33 PDT

If connections of a UniqueIDBDatabase are all closed and there is no pending request on the UniqueIDBDatabase, the UniqueIDBDatabase may not be used any more.

Attachments
Patch (5.57 KB, patch) 2020-03-24 23:22 PDT, Sihui Liu	no flags	Details Formatted Diff Diff
Patch for landing (5.71 KB, patch) 2020-03-25 22:44 PDT, Sihui Liu	no flags	Details Formatted Diff Diff
Patch for landing (5.28 KB, patch) 2020-03-30 11:51 PDT, Sihui Liu	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Sihui Liu

Comment 1 2020-03-24 23:22:54 PDT

Created attachment 394473 [details] Patch

Geoffrey Garen

Comment 2 2020-03-25 12:33:53 PDT

What's the motivation for this change? Can we test it somehow?

Sihui Liu

Comment 3 2020-03-25 13:42:07 PDT

(In reply to Geoffrey Garen from comment #2) > What's the motivation for this change? > > Can we test it somehow? It is actually the old behavior before IDB background thread change. We don't want to keep the UniqueIDBDatabase objects in memory if they may never be used again. Current behavior is once UniqueIDBDatabase is created it will be in the map unless IDB data is deleted. I've tested the patch this manually. This should not cause any behavior change other than less memory in the case of opening a lot of IDBDatabase, closing them, and never using them again.

Geoffrey Garen

Comment 4 2020-03-25 16:32:37 PDT

Comment on attachment 394473 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394473&action=review r=me > Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:1198 > +void UniqueIDBDatabase::destroyIfPossible() Does this function delete the UniqueIDBDatabase object, or just disconnect it from the server? I think a better name might be "tryRemoveFromServer" or "tryClose".

Sihui Liu

Comment 5 2020-03-25 17:56:18 PDT

Comment on attachment 394473 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394473&action=review >> Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:1198 >> +void UniqueIDBDatabase::destroyIfPossible() > > Does this function delete the UniqueIDBDatabase object, or just disconnect it from the server? > > I think a better name might be "tryRemoveFromServer" or "tryClose". IDBServer owns UniqueIDBDatabase; this function deletes the object by removing it from the IDBServer. Will change the name to tryCloseAndRemoveFromServer.

Sihui Liu

Comment 6 2020-03-25 22:44:55 PDT

Created attachment 394581 [details] Patch for landing

EWS

Comment 7 2020-03-25 23:26:57 PDT

Committed r259034: <https://trac.webkit.org/changeset/259034> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394581 [details].

Radar WebKit Bug Importer

Comment 8 2020-03-25 23:27:14 PDT

<rdar://problem/60906908>

WebKit Commit Bot

Comment 9 2020-03-28 06:06:04 PDT

Re-opened since this is blocked by bug 209700

Sihui Liu

Comment 10 2020-03-30 11:51:55 PDT

Created attachment 394943 [details] Patch for landing

EWS

Comment 11 2020-03-30 12:23:11 PDT

Committed r259215: <https://trac.webkit.org/changeset/259215> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394943 [details].

Note You need to log in before you can comment on or make changes to this bug.