Bug 209477
| Summary: | [Slack] the #changes channel is too noisy and uncurated | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <pnormand> |
| Component: | Tools / Tests | Assignee: | Yusuke Suzuki <ysuzuki> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aakash_jain, ap, jbedard, jond, ryanhaddad, webkit-bug-importer, ysuzuki |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Philippe Normand
It would be great to have messages sent to that channel in a format similar to what the WKR IRC bot was using.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
I've been told that this is just showing RSS feed from Trac. Feedback accepted and I would personally also prefer a more compact format, but this would be a replacement, not adjustment.
Aakash Jain
Yeah. Seems like it gets the RSS feed from this url: https://trac.webkit.org/timeline?changeset=on&wiki=on&max=50&authors=&daysback=90&format=rss
Jonathan Bedard
Are we looking for something like this: https://results.webkit.org/commits? (with the one-line toggle)
I feel like WKR IRC bot basically spat out single lines, but I don't exactly remember
Philippe Normand
Here's an example, from the good old times:
<WKR> https://trac.webkit.org/r258848 by Devin Rousso (drousso) Web Inspector: Uncaught Exception: TypeError: this._springEditor.removeListeners is not a function. (In 'this._springEditor.removeListeners()', 'this._springEditor.removeListeners' is undefined) https://webkit.org/b/209325 Reviewed by Brian Burg (bburg).
Philippe Normand
So somethings like:
<trac commit link> by <author fullname + handle/nickname> <commit headline, probably clipped to an acceptable amount of characters> <bugzilla link> Reviewed by <reviewer fullname + handle/nickname>
Aakash Jain
(In reply to Philippe Normand from comment #5)
> <trac commit link> by <author fullname + handle/nickname> <commit headline, probably clipped to an acceptable amount of characters> <bugzilla link> Reviewed by <reviewer fullname + handle/nickname>
The code to generate this message is in: https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py#L115 : _summarize_commit_log()
Yusuke Suzuki
As a first step, I've just connected github.com/WebKit/webkit's commits to #changes channel instead of using RSS from trac.webkit.org. Let's see how it is formatted in slack. If this is not desirable, we could change it in detailed way by using web-hook based approach (webhook from github.com/WebKit/webkit to slack).
Yusuke Suzuki
I think this is now changed.
Radar WebKit Bug Importer
<rdar://problem/63803716>