Bug 209476

Summary: Pass hardness for test numberingSystemsForLocale-cached-... through test header
Product: WebKit Reporter: Paulo Matos <pmatos>
Component: New BugsAssignee: Paulo Matos <pmatos>
Status: RESOLVED FIXED    
Severity: Normal CC: ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Paulo Matos
Reported 2020-03-24 07:32:34 PDT
Pass hardness for test numberingSystemsForLocale-cached-... through test header
Attachments
Patch (2.86 KB, patch)
2020-03-24 07:34 PDT, Paulo Matos 		no flags
DetailsFormatted DiffDiff
Patch (2.86 KB, patch)
2020-03-26 04:06 PDT, Paulo Matos 		no flags
DetailsFormatted DiffDiff
Patch (2.85 KB, patch)
2020-03-26 07:35 PDT, Paulo Matos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Paulo Matos
Comment 1 2020-03-24 07:34:36 PDT
Created attachment 394365 [details] Patch
Caio Lima
Comment 2 2020-03-24 08:22:44 PDT
Comment on attachment 394365 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394365&action=review > JSTests/stress/numberingSystemsForLocale-cached-strings-should-be-immortal-and-safe-for-concurrent-access.js:2 > +//@ requireOptions("-e", "let hardness=25") if ["arm", "mips"].include?($architecture) It think it would be better if we had `if ["arm", "mips"].include?($architecture) then requireOptions("-e", "let hardness=25") else requireOptions("-e", "let hardness=100") end`. This way we avoid multiple calls to `requireOptions`.
Paulo Matos
Comment 3 2020-03-25 01:20:19 PDT
(In reply to Caio Lima from comment #2) > Comment on attachment 394365 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=394365&action=review > > > JSTests/stress/numberingSystemsForLocale-cached-strings-should-be-immortal-and-safe-for-concurrent-access.js:2 > > +//@ requireOptions("-e", "let hardness=25") if ["arm", "mips"].include?($architecture) > > It think it would be better if we had `if ["arm", > "mips"].include?($architecture) then requireOptions("-e", "let hardness=25") > else requireOptions("-e", "let hardness=100") end`. This way we avoid > multiple calls to `requireOptions`. We are only making a call here, unless it's arm or mips. I initially had followed your suggestion but the line length is a problem and unless there's a way to break a line in the test header, I see no way around it.
Paulo Matos
Comment 4 2020-03-26 04:06:21 PDT
Created attachment 394593 [details] Patch
Paulo Matos
Comment 5 2020-03-26 07:35:41 PDT
Created attachment 394608 [details] Patch
Yusuke Suzuki
Comment 6 2020-03-27 07:46:30 PDT
Comment on attachment 394608 [details] Patch r=me
EWS
Comment 7 2020-03-27 07:52:01 PDT
Committed r259114: <https://trac.webkit.org/changeset/259114> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394608 [details].
Radar WebKit Bug Importer
Comment 8 2020-03-27 07:53:18 PDT
<rdar://problem/60967497>
Note You need to log in before you can comment on or make changes to this bug.