Bug 209402
| Summary: | [GTK] Wrong media download context menu item in audio context menus | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | Media | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | mcatanzaro, pnormand |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Linux | ||
Michael Catanzaro
Open https://upload.wikimedia.org/wikipedia/commons/9/90/Papalotla-sound.ogg, right click (very carefully!) on the click target. Notice the menu item says "Download Video" when it should say "Download Audio". Problem is that WebKit's default context menu contains WEBKIT_CONTEXT_MENU_ACTION_DOWNLOAD_VIDEO_TO_DISK when it should contain WEBKIT_CONTEXT_MENU_ACTION_DOWNLOAD_AUDIO_TO_DISK.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
(In reply to Michael Catanzaro from comment #0)
> Problem is that
> WebKit's default context menu contains
> WEBKIT_CONTEXT_MENU_ACTION_DOWNLOAD_VIDEO_TO_DISK when it should contain
> WEBKIT_CONTEXT_MENU_ACTION_DOWNLOAD_AUDIO_TO_DISK.
(Epiphany constructs its own context menus, but it does so using WebKit's default context menu actions. The Epiphany code is constructed such that fixing this bug in WebKit will automatically fix it in Epiphany as well.)
Philippe Normand
For this ogg file, MediaDocument creates a <video> element, which I suppose is expected because only given the mime-type it can't know if this is a video or audio file (ogg is a container, can store audio and/or video).
Not much we can do here I'm afraid.