Bug 209366 – Web Inspector: REGRESSION(r257380, r257759): focusing the inspected page when docked dims most of the interface

• Component: Web Inspector
• Status: RESOLVED FIXED

[Devin Rousso]

# STEPS TO REPRODUCE:
1. inspect any page
2. dock Web Inspector
3. click anywhere in the inspected page
=> the Web Inspector tab bar dims

This should only happen when detached.  We should only be dimming certain selected items, like `WI.TreeElement` or `WI.DataGridNode`.

# STEPS TO REPRODUCE:
1. inspect any page
2. dock Web Inspector
3. select any node in the Elements Tab
4. click anywhere in the inspected page
=> the selected node from step #3 doesn't dim

[Devin Rousso]

Created attachment 394146 [details]
Patch

[Nikita Vasilyev]

Comment on attachment 394146 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394146&action=review

Thank you for fixing these.

> Source/WebInspectorUI/UserInterface/Views/BreakpointTreeElement.css:44
> +.tree-outline .item.breakpoint.selected:focus .status > .status-image.resolved {

Note that if we ever support multiple item selection for this treeOutline, than it would need to change from:

    .tree-outline .item.selected:focus

to

    .tree-outline:focus-within .item.selected

This also applies to a bunch of cases below.

[Devin Rousso]

Created attachment 394149 [details]
Patch

[EWS]

Committed r258809: <https://trac.webkit.org/changeset/258809>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394149 [details].

[Radar WebKit Bug Importer]

<rdar://problem/60727498>