Summary: | Reload of page with an iframe does not refresh iframe content, even if iframe src url changed | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antony Sargent <antony> | ||||
Component: | Frames | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, aroben, bdakin, erikkay, mike.tsao, mmoss, ojan | ||||
Priority: | P2 | Keywords: | HasReduction, InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
URL: | http://asargent.com/tests/iframe.php | ||||||
Attachments: |
|
Description
Antony Sargent
2008-09-18 17:07:31 PDT
Can you put those on a server and give us a test URL? (In reply to comment #1) > Can you put those on a server and give us a test URL? > http://asargent.com/tests/iframe.php Hit reload a few times in firefox/ie and then in a webkit browser and you should see the difference in behavior. As far as I can tell this works correctly in the latest nightly of WebKit on Mac OS X at this time: r36640. It definitely fails with Safari 3.1.2 on Mac OS X. On Windows with the latest nightly (r36647), reloading the page via Ctrl-R shows the bug while loading the page again via Ctrl-L, Return does not. This affects iframe-based social networking applications, particularly those using either Facebook or OAuth authentication schemes. The credentials are contained in the iframe src URL, and by their own terms they expire after some number of minutes. Upshot is many social-networking applications die after a few minutes, and for some users it's a hard state for them to get out of (F5 and "just clicking around") don't fix the problem. So, let me get this straight. This is fixed on TOT on the Mac, but on Windows TOT we only do the right thing with a Ctrl-L and not Ctrl-R. And so the remaining bug is that we want this behavior with Ctrl-R as well as Ctrl-L on Windows? Or is our current behavior correct? Created attachment 24861 [details]
proposed fix (sync with related Mac code)
Comment on attachment 24861 [details] proposed fix (sync with related Mac code) You should consider setting the CHANGE_LOG_NAME environment variable to your full name. It seems on google systems the prepare-ChangeLog code is picking up teh username instead: my $name = $ENV{CHANGE_LOG_NAME} || $ENV{REAL_NAME} || gitConfig("user.name") || (split /\s*,\s*/, (getpwuid $<)[6])[0] || "set REAL_NAME environment variable"; This looks identical to http://trac.webkit.org/changeset/31264 which would suggest to me it's right. I'm going to r+ this, but I don't have a working tree on this box atm, so I can't land it immediately. Comment on attachment 24861 [details]
proposed fix (sync with related Mac code)
About to land. ChangeLog entries should also include a link to the original bugzilla bug as well.
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/platform/win/Skipped M WebKit/win/ChangeLog M WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp Committed r38912 |