Bug 209247

Summary: Several TextMarker attributes need to run on the main thread.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, darin, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Andres Gonzalez 2020-03-18 13:11:25 PDT 
Several TextMarker attributes need to run on the main thread.
Comment 1 Andres Gonzalez 2020-03-18 13:21:36 PDT 
Created attachment 393894 [details]
Patch
Comment 2 EWS 2020-03-18 19:09:50 PDT 
Committed r258673: <https://trac.webkit.org/changeset/258673>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 393894 [details].
Comment 3 Radar WebKit Bug Importer 2020-03-18 19:10:13 PDT 
<rdar://problem/60613926>
Comment 4 Darin Adler 2020-03-18 20:26:37 PDT 
Comment on attachment 393894 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393894&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:560
> +static inline RetainPtr<WebAccessibilityObjectWrapper> retainWrapper(WebAccessibilityObjectWrapper* wrapper)
> +{
> +    return RetainPtr<WebAccessibilityObjectWrapper>(wrapper);
> +}

I’m surprised we need this. Doesn’t the retainPtr function from RetainPtr.h work?
Comment 5 Andres Gonzalez 2020-03-18 21:19:01 PDT 
(In reply to Darin Adler from comment #4)
> Comment on attachment 393894 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=393894&action=review
> 
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:560
> > +static inline RetainPtr<WebAccessibilityObjectWrapper> retainWrapper(WebAccessibilityObjectWrapper* wrapper)
> > +{
> > +    return RetainPtr<WebAccessibilityObjectWrapper>(wrapper);
> > +}
> 
> I’m surprised we need this. Doesn’t the retainPtr function from RetainPtr.h
> work?

I misread your comment about this in a previous review as that should use a helper function, but didn't realize that retainPtr already existed. Fixed it in:

https://bugs.webkit.org/show_bug.cgi?id=209269

Thanks very much.