Bug 209150

Summary: Sync web-platform-tests/css/css-cascade from upstream
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: CSSAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Enhancement CC: cdumez, commit-queue, koivisto, rniwa, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alexey Shvayka
Reported 2020-03-16 15:27:21 PDT Comment hidden (obsolete)
Attachments
Patch (47.14 KB, patch)
2020-03-16 15:35 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Patch (54.96 KB, patch)
2020-03-17 01:01 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Patch (54.97 KB, patch)
2020-03-17 01:59 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexey Shvayka
Comment 1 2020-03-16 15:35:10 PDT
Created attachment 393693 [details] Patch
Alexey Shvayka
Comment 2 2020-03-17 01:01:01 PDT
Created attachment 393733 [details] Patch Add missing expected result.
youenn fablet
Comment 3 2020-03-17 01:20:36 PDT
Comment on attachment 393733 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393733&action=review > LayoutTests/TestExpectations:1810 > +[ Debug ] imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html [ Pass Crash ] If it is crashing, let's skip it in Debug for now and let's file a bug.
Alexey Shvayka
Comment 4 2020-03-17 01:59:03 PDT
Created attachment 393736 [details] Patch Set reviewer, link crashing test to bug and skip it.
WebKit Commit Bot
Comment 5 2020-03-17 03:14:07 PDT
Comment on attachment 393736 [details] Patch Clearing flags on attachment: 393736 Committed r258543: <https://trac.webkit.org/changeset/258543>
WebKit Commit Bot
Comment 6 2020-03-17 03:14:09 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2020-03-17 03:15:16 PDT
<rdar://problem/60532970>
Alexey Shvayka
Comment 8 2020-03-17 03:42:08 PDT
Committed r258544: <https://trac.webkit.org/changeset/258544>
Alexey Shvayka
Comment 9 2020-03-17 03:46:12 PDT
(In reply to Alexey Shvayka from comment #8) > Committed r258544: <https://trac.webkit.org/changeset/258544> This change adds iOS expectations for crashing test, which are slightly different: --- a/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt +++ b/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt @@ -345,6 +345,7 @@ PASS -webkit-mask-repeat PASS -webkit-mask-size PASS -webkit-mask-source-type PASS -webkit-nbsp-mode +PASS -webkit-overflow-scrolling PASS -webkit-print-color-adjust PASS -webkit-rtl-ordering PASS -webkit-ruby-position @@ -359,6 +360,7 @@ PASS -webkit-text-size-adjust PASS -webkit-text-stroke-color PASS -webkit-text-stroke-width PASS -webkit-text-zoom +PASS -webkit-touch-callout PASS -webkit-transform-style PASS -webkit-user-drag PASS -webkit-user-modify
Note You need to log in before you can comment on or make changes to this bug.