Bug 209123

Summary: Simplify ChromeClient.createWindow
Product: WebKit Reporter: Rob Buis <rbuis>
Component: New BugsAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, ews-watchlist, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Rob Buis
Reported 2020-03-15 07:17:27 PDT
Simplify ChromeClient.createWindow by removing the FrameLoadRequest parameter ; it was only passed for its ResourceRequest member, which can also be obtained from the NavigationAction parameter.
Attachments
Patch (18.00 KB, patch)
2020-03-15 07:28 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-03-15 07:28:05 PDT
Created attachment 393617 [details] Patch
WebKit Commit Bot
Comment 2 2020-03-16 00:20:33 PDT
Comment on attachment 393617 [details] Patch Clearing flags on attachment: 393617 Committed r258487: <https://trac.webkit.org/changeset/258487>
WebKit Commit Bot
Comment 3 2020-03-16 00:20:35 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2020-03-16 00:21:15 PDT
<rdar://problem/60485129>
Note You need to log in before you can comment on or make changes to this bug.