Bug 209107 – Share HitTestResult::addNodeToListBasedTestResult() impl for LayoutRect and FloatRect overloads

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Daniel Bates]

There are two overloads HitTestResult::addNodeToListBasedTestResult(): one for LayoutRect and one for FloatRect. Maybe one of the overloads is not necessary. I don't know, yet, but the implementation of these overloads are identical. As a first step towards future simplifications let's share the implementation and thus remove duplication.

[Daniel Bates]

Created attachment 393585 [details]
Patch

[Daniel Bates]

Comment on attachment 393585 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393585&action=review

> Source/WebCore/rendering/HitTestResult.h:152
> +    template<typename RectType> HitTestProgress addNodeToListBasedTestResultCommon(Node*, const HitTestRequest&, const HitTestLocation&, const RectType&);

Could also make node const....I'll try and maybe fold it into this patch.

[Daniel Bates]

Comment on attachment 393585 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393585&action=review

>> Source/WebCore/rendering/HitTestResult.h:152
>> +    template<typename RectType> HitTestProgress addNodeToListBasedTestResultCommon(Node*, const HitTestRequest&, const HitTestLocation&, const RectType&);
> 
> Could also make node const....I'll try and maybe fold it into this patch.

Actually, I am not going to do this in this patch as I would need to fix up more things....

[Daniel Bates]

Thanks for the review!

[Daniel Bates]

Comment on attachment 393585 [details]
Patch

Clearing flags on attachment: 393585

Committed r258468: <https://trac.webkit.org/changeset/258468>

[Daniel Bates]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/60457690>