Bug 209100

Summary: [Tree building] Reset the fragmented flow status before calling child.willBeRemovedFromTree.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2020-03-13 20:44:21 PDT
willBeRemovedFromTree assumes all the cleanup has already happened.
Attachments
Patch (3.93 KB, patch)
2020-03-13 20:51 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (3.99 KB, patch)
2020-03-14 04:31 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2020-03-13 20:44:39 PDT
<rdar://problem/60434672>
alan
Comment 2 2020-03-13 20:51:17 PDT
Created attachment 393571 [details] Patch
Simon Fraser (smfr)
Comment 3 2020-03-13 20:54:39 PDT
Comment on attachment 393571 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393571&action=review > Source/WebCore/ChangeLog:3 > + [Tree building] Reset the fragmented flow status before signal will-be-removed. Maybe "before calling child.willBeRemovedFromTree()" > Source/WebCore/ChangeLog:9 > + ::willBeRemoved() assumes all the cleanup has happened and it's the final step before calling d'tor. It this referring to the child.willBeRemovedFromTree()?
alan
Comment 4 2020-03-14 04:31:31 PDT
Created attachment 393582 [details] Patch
alan
Comment 5 2020-03-14 04:32:22 PDT
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 393571 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=393571&action=review > > > Source/WebCore/ChangeLog:3 > > + [Tree building] Reset the fragmented flow status before signal will-be-removed. > > Maybe "before calling child.willBeRemovedFromTree()" > > > Source/WebCore/ChangeLog:9 > > + ::willBeRemoved() assumes all the cleanup has happened and it's the final step before calling d'tor. > > It this referring to the child.willBeRemovedFromTree()? Correct. I confused it with willBeDestroyed.
WebKit Commit Bot
Comment 6 2020-03-14 05:57:40 PDT
Comment on attachment 393582 [details] Patch Clearing flags on attachment: 393582 Committed r258466: <https://trac.webkit.org/changeset/258466>
WebKit Commit Bot
Comment 7 2020-03-14 05:57:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.