Summary: | Remove AffectedByDrag style flag | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | allan.jensen, cdumez, cmarcelo, commit-queue, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kangil.han, kondapallykalyan, macpherson, menard, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Antti Koivisto
2020-03-13 08:48:59 PDT
Created attachment 393490 [details]
patch
Comment on attachment 393490 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=393490&action=review Dragging is under tested, so some manual testing of this is warranted. > Source/WebCore/dom/Element.h:318 > + bool isDragged() const { return isUserActionElement() && isUserActionElementDragged(); } isDragged is weird. isBeingDragged? > Source/WebCore/dom/Element.h:324 > + void setDragged(bool); setIsBeingDragged? > Source/WebCore/dom/Node.h:612 > + ChildrenAffectedByForwardPositionalRules = 1 << 1, > + DescendantsAffectedByForwardPositionalRules = 1 << 2, > + ChildrenAffectedByBackwardPositionalRules = 1 << 3, > + DescendantsAffectedByBackwardPositionalRules = 1 << 4, > + ChildrenAffectedByPropertyBasedBackwardPositionalRules = 1 << 5, I would align the = but that's just me. Created attachment 393504 [details]
patch
Comment on attachment 393504 [details] patch Clearing flags on attachment: 393504 Committed r258416: <https://trac.webkit.org/changeset/258416> All reviewed patches have been landed. Closing bug. Comment on attachment 393490 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=393490&action=review > Source/WebCore/dom/UserActionElementSet.h:58 > enum class Flag { : uint8_t maybe? > Source/WebCore/dom/UserActionElementSet.h:63 > + IsActive = 1 << 0, > + InActiveChain = 1 << 1, > + IsHovered = 1 << 2, > + IsFocused = 1 << 3, > + IsDragged = 1 << 4, I’m like the opposite of Simon. I would not have lined these up, and it’s just me saying that ;) I'm totally in line-up camp, I just forgot to do it with this enum in the original patch! I wish this was a language feature. (In reply to Antti Koivisto from comment #9) > I wish this was a language feature. We should just clang-format everything! Hand-indenting these is not that hard either. I meant a C++ feature to generate bit enums without the silly 1 << n dance. |