Bug 209015 – [ANGLE] Source/ThirdParty/ANGLE/src/libANGLE/Display.h:221:73: warning: implicitly-declared ‘egl::AttributeMap& egl::AttributeMap::operator=(const egl::AttributeMap&)’ is deprecated [-Wdeprecated-copy]

• Component: ANGLE
• Status: RESOLVED FIXED

[Michael Catanzaro]

[398/1919] Building CXX object Source/...r/src/libANGLE/FrameCapture_mock.cpp.o
In file included from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/entry_points_utils.h:17,
                 from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/FrameCapture.h:16,
                 from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/FrameCapture_mock.cpp:10:
/home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/Display.h: In member function ‘void egl::Display::setAttributes(const egl::AttributeMap&)’:
/home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/Display.h:221:73: warning: implicitly-declared ‘egl::AttributeMap& egl::AttributeMap::operator=(const egl::AttributeMap&)’ is deprecated [-Wdeprecated-copy]
  221 |     void setAttributes(const AttributeMap &attribMap) { mAttributeMap = attribMap; }
      |                                                                         ^~~~~~~~~
In file included from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/Debug.h:15,
                 from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/State.h:18,
                 from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/Context.h:52,
                 from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/FrameCapture.h:14,
                 from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/FrameCapture_mock.cpp:10:
/home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/AttributeMap.h:24:5: note: because ‘egl::AttributeMap’ has user-provided ‘egl::AttributeMap::AttributeMap(const egl::AttributeMap&)’
   24 |     AttributeMap(const AttributeMap &other);
      |     ^~~~~~~~~~~~

[Michael Catanzaro]

Created attachment 393410 [details]
Patch

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE

[WebKit Commit Bot]

Comment on attachment 393410 [details]
Patch

Clearing flags on attachment: 393410

Committed r258483: <https://trac.webkit.org/changeset/258483>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/60478335>

[Konstantin Tokarev]

Comment on attachment 393410 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393410&action=review

> Source/ThirdParty/ANGLE/ChangeLog:10
> +        using.

That's fine, but I guess it would be a good idea to CC ANGLE folks

[Kenneth Russell]

Thanks for the CC. Filed this against the ANGLE project as https://bugs.chromium.org/p/angleproject/issues/detail?id=4486 .