Bug 209014 – [ANGLE] Source/ThirdParty/ANGLE/src/common/utilities.cpp:10: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]

• Component: ANGLE
• Status: RESOLVED FIXED

[Michael Catanzaro]

ANGLE is using #pragma clang diagnostic outside of clang guards:

[214/1919] Building CXX object Source/...s/ANGLE.dir/src/common/utilities.cpp.o
/home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/common/utilities.cpp:10: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
   10 | #pragma clang diagnostic ignored "-Wglobal-constructors"
      |

All uses need to be guarded properly. GCC will warn whenever it sees another compiler's pragma.

[Michael Catanzaro]

It's a downstream WebKit problem, added in our changes.diff:

diff --git a/src/common/utilities.cpp b/src/common/utilities.cpp
index 87932a53f..83ea168e2 100644
--- a/src/common/utilities.cpp
+++ b/src/common/utilities.cpp
@@ -6,6 +6,9 @@
 
 // utilities.cpp: Conversion functions and other utility routines.
 
+// Older clang versions have a false positive on this warning here.
+#pragma clang diagnostic ignored "-Wglobal-constructors"
+
 #include "common/utilities.h"
 #include <GLSLANG/ShaderVars.h>
 #include "GLES3/gl3.h"

[Michael Catanzaro]

Created attachment 393408 [details]
Patch

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE

[WebKit Commit Bot]

Comment on attachment 393408 [details]
Patch

Clearing flags on attachment: 393408

Committed r258484: <https://trac.webkit.org/changeset/258484>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/60478777>