Summary: | [ANGLE] Source/ThirdParty/ANGLE/src/common/utilities.cpp:10: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas] | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||
Component: | ANGLE | Assignee: | Michael Catanzaro <mcatanzaro> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, darin, dino, ews-watchlist, graouts, kondapallykalyan, mcatanzaro, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Michael Catanzaro
2020-03-12 13:18:13 PDT
It's a downstream WebKit problem, added in our changes.diff: diff --git a/src/common/utilities.cpp b/src/common/utilities.cpp index 87932a53f..83ea168e2 100644 --- a/src/common/utilities.cpp +++ b/src/common/utilities.cpp @@ -6,6 +6,9 @@ // utilities.cpp: Conversion functions and other utility routines. +// Older clang versions have a false positive on this warning here. +#pragma clang diagnostic ignored "-Wglobal-constructors" + #include "common/utilities.h" #include <GLSLANG/ShaderVars.h> #include "GLES3/gl3.h" Created attachment 393408 [details]
Patch
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE Comment on attachment 393408 [details] Patch Clearing flags on attachment: 393408 Committed r258484: <https://trac.webkit.org/changeset/258484> All reviewed patches have been landed. Closing bug. |